Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-toolbars: Show tool icons for all viewModes #10810

Merged
merged 1 commit into from
May 17, 2020

Conversation

shilman
Copy link
Member

@shilman shilman commented May 17, 2020

Issue: N/A

Related to #6700

What I did

global-args-toolbars

addon-toolbars uses globalArgs, which is compatible with all viewModes, so we can show it no matter what viewMode we're in.

We can probably do something similar for addon-backgrounds once it gets docs compatibility. @yannbf

Not sure what other addons this applies to, but it's a step forward!

Self-merging cc @lifeiscontent @ndelangen @patricklafrance

How to test

See official-storybook and attached gif

@shilman shilman added this to the 6.0 args milestone May 17, 2020
@shilman shilman merged commit fa914a7 into next May 17, 2020
@patricklafrance
Copy link
Member

@shilman 👌🏻👌🏻

@stof stof deleted the 6700-global-toolbars-buttons branch May 25, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants