Essentials: Add addon-docs #10729
Merged
Essentials: Add addon-docs #10729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this setup work out of the box for typescript users as well? |
|
@yannbf yes it should work for TS users. there are some open questions about changes to the CRA preset and the typescript preset, but docs itself should work out of the box if those are configured properly |
…to-disable Essentials: Update auto disable heuristics based on main.js
|
Self-merging @ndelangen @tmeasday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #10723
What I did
Add addon-docs to essentials
How to test
See
cra-ts-essentialsexample