Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: react-scripts stories homogenization #10710

Merged
merged 1 commit into from
May 11, 2020
Merged

cli: react-scripts stories homogenization #10710

merged 1 commit into from
May 11, 2020

Conversation

tooppaaa
Copy link
Contributor

@tooppaaa tooppaaa commented May 9, 2020

Issue:

We need similar stories after generation to run e2e against

Part of #10702

@tooppaaa tooppaaa added maintenance User-facing maintenance tasks cli react cra Prioritize create-react-app compatibility labels May 9, 2020
@tooppaaa tooppaaa mentioned this pull request May 9, 2020
Merged
13 tasks
@yannbf yannbf mentioned this pull request May 10, 2020
Closed
2 tasks
@tooppaaa tooppaaa merged commit 9ed15c4 into next May 11, 2020
@tooppaaa tooppaaa deleted the generator_reactScripts branch May 11, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@shilman shilman Awaiting requested review from shilman

@stijnkoopal stijnkoopal Awaiting requested review from stijnkoopal

Assignees

@tooppaaa tooppaaa

@yannbf yannbf

@ndelangen ndelangen

@gaetanmaisse gaetanmaisse

Labels
cli cra Prioritize create-react-app compatibility maintenance User-facing maintenance tasks react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tooppaaa @ndelangen @yannbf @gaetanmaisse