Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX background color of the panel #10612

Merged
merged 1 commit into from
May 2, 2020
Merged

FIX background color of the panel #10612

merged 1 commit into from
May 2, 2020

Conversation

ndelangen
Copy link
Member

Issue: #10597

What I did

Panel content should be content background color.

@ndelangen ndelangen added this to the 6.0 milestone May 1, 2020
@ndelangen ndelangen requested a review from domyen May 1, 2020 14:21
@ndelangen ndelangen requested a review from tmeasday as a code owner May 1, 2020 14:21
@ndelangen ndelangen self-assigned this May 1, 2020
@ndelangen ndelangen requested a review from hipstersmoothie May 1, 2020 14:21
shilman
shilman reviewed May 2, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea what change broke this?

@shilman shilman mentioned this pull request May 2, 2020
Closed
@ndelangen
Copy link
Member Author

I must have removed some div-wrapper I though was unnecessary in the past @shilman

@ndelangen ndelangen merged commit b843da8 into next May 2, 2020
@ndelangen ndelangen deleted the fix/10597-panel-background branch May 2, 2020 11:11
@shilman shilman mentioned this pull request May 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman left review comments

@domyen domyen Awaiting requested review from domyen

@tmeasday tmeasday Awaiting requested review from tmeasday

@hipstersmoothie hipstersmoothie Awaiting requested review from hipstersmoothie

Assignees

@ndelangen ndelangen

Labels
bug ui
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @shilman