Addon-docs: Add controls to ArgsTable #10354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Tom Coleman <[email protected]>
…to 6639-args-table
shilman
changed the title
shilman
requested review from
saponifi3d,
stijnkoopal,
theinterned,
thomasbertet and
z4o4z
as code owners
tmeasday
approved these changes
Apr 14, 2020
| `); | ||
| }); | ||
|
|
||
| it('extracted argTypes take precedence over inferred argTypes', () => { |
| `); | ||
| }); | ||
|
|
||
| it('user-specified argTypes take precedence over inferred argTypes', () => { |
There was a problem hiding this comment.
I wonder about this too.. I guess it'll come out in the wash when the rubber hits the road...
This was referenced Apr 15, 2020
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6639
What I did
This is the second of a series of PRs to add controls (formerly known as "knobs") to the Props block:
This is a telescoping PR that targets the first step, and will solve a few of the outstanding issues from that PR. It's separated to make it easier to review.
Open questions
Objectcontrol. I'm wondering whether we need to have an 'unknown' type (???) where we show no control at all. We could use this for React types, for example.Key files to review
How to test