-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Fix viewMode
parameter handling
#10292
Conversation
Looks good to me. So it will be possible to define // my-component.stories.js
playground.story = {
parameters: {
viewMode: 'story',
},
}
|
viewMode
parameter handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good conceptually, but maybe buggy?
Seems to work to me: Try navigating to a different story, click canvas, then navigate to that story again, it switching you to viewMode=docs |
Issue: #10233
What I did
Made a change in lib/api/modules/stories so when navigating to a story, the parameter is read and preferred over the current state
WDYT @jonhuteau ?