Ensure visibility of links within PropRow descriptions #10210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
approved these changes
Mar 25, 2020
shilman
added
the
patch:yes
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Mar 31, 2020
Ensure visibility of links within PropRow descriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Links within prop descriptions are not visible.
What I did
I changed the style of links within prop descriptions so they can be differentiated from regular text.
Before:
After:
How to test
I’m not sure if this MR needs anything else, could you please let me know and I'll add whatever is required 😊