You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Check for multiple stories before rendering the the Stories component in the DocsPage. Without this check, unnecessary rendering of the Stories component headline would occur.
Expect to not see a "Stories" headline with nothing underneath it.
Steps to reproduce
Go to the examples HTML storybook app and check out a component that only has one story. For example, '/docs/addons-centered--story-1'. You will see that there is a headline at the bottom that reads "Stories". This headline is not needed. This happens in react/angular ETC ETC too. Just using the HTML one as an example to help explain the problem.
This is current in SB HTML. You can see the unneeded "Stories" heading.
This is with my PR #9269. The heading is removed because there is only one story.
Please specify which version of Storybook and optionally any affected addons that you're running
@storybook/html x v5.3.0-rc.4
@storybook/addon-docs v5.3.0-rc.4
but happens in all frameworks!
The text was updated successfully, but these errors were encountered:
afebbraro
changed the title
Added a check for multiple stories before rendering the the Stories component in the DocsPage.
Add a check for multiple stories before rendering the the Stories component in the DocsPage.
Dec 30, 2019
afebbraro
changed the title
Add a check for multiple stories before rendering the the Stories component in the DocsPage.
[addon-docs] Add a check for multiple stories before rendering the Stories component in the DocsPage.
Dec 30, 2019
Bug or support request summary
Check for multiple stories before rendering the the Stories component in the DocsPage. Without this check, unnecessary rendering of the Stories component headline would occur.
Expect to not see a "Stories" headline with nothing underneath it.
Steps to reproduce
Go to the examples HTML storybook app and check out a component that only has one story. For example, '/docs/addons-centered--story-1'. You will see that there is a headline at the bottom that reads "Stories". This headline is not needed. This happens in react/angular ETC ETC too. Just using the HTML one as an example to help explain the problem.
This is current in SB HTML. You can see the unneeded "Stories" heading.
This is with my PR #9269. The heading is removed because there is only one story.
Please specify which version of Storybook and optionally any affected addons that you're running
@storybook/html x v5.3.0-rc.4
@storybook/addon-docs v5.3.0-rc.4
but happens in all frameworks!
The text was updated successfully, but these errors were encountered: