-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter and search components by tag #7711
Comments
I wonder if this could be made slightly more generic and filter by |
Agreed, being able to filter in some sort of generic pattern would be helpful. |
Cc @ghengeveld |
Currently, it looks like the fields that are indexed for search ( |
I don't think it'll become configurable, but we're definitely keen to improve on it with well-defined features such as tags. Configurable things are a huge pain in the long term because of unknown potential conflicts down the road. |
+1 this is going to be super useful for discovery |
+1 It is a crucial feature for large storybooks with a lot of content. |
+1 we need this |
+1 Really in need of this. |
+1 Need this |
Will this be possible in Storybook 7? |
Update: We implemented the technical underpinnings to support tags in 7.0. Tags power the new automatic docgen functionality. But it doesn't yet do the filtering - which will come in future releases. Also, we(maintainers) are super open to contributors who want to help us make filtering and search by tags a reality. That would really help us accelerate this work! |
Is there any initiative to - apart from search by tags - allow a full text search? Content in MDX documents and descriptions of stories (doc comments) will not benefit from indexing just tags from |
I'll add a +1 to this. Came up in a couple of research calls recently. It's especially useful for large storybooks. |
@domyen Could you share a bit more about what related work has been done, and how that enables the feature? Also possibly pinpoint a few files / places where to start? |
I'm also interested in contributing to this effort but don't have much context to get started. Honestly, I was hoping this was closer to coming to fruition. Would this be possible by creating a new plugin? |
Maybe https://pagefind.app/ will be a solution worth considering? It's integrated in https://starlight.astro.build which I recently checked out an it works pretty well there. Later the UI in there got a bit more complex, withastro/starlight@e5a2e09#diff-75edb5fd723800e6c6dc2e05eaa90c02510d9bff433746a52839e980459712f0 but it still seems like a low-hanging fruit For Storybook (at least for mine, where I use Vite builder) stack is Storybook -> Vite -> Rollup EDIT |
Oh that's really interesting! This makes it feasible to search for more than just story metadata (component and story name), such as the actual content. |
@ghengeveld maybe it then deserves a distinct issue created, if it's broader than just about tags? |
Yeah I think so. This ticket is about separating search and tags, while replacing search altogether is likely a bigger project. If not picked up by the community then this will have to go on the "betting table" (Shape Up) to get prioritized, which requires a written pitch (proposal). |
I took a look at what's the output of I created a #24831 for discussing that idea |
Tag filtering RFC here #25535 |
How can we get this moved forward? I think this would be a game changer for Storybook. One of the biggest complaints we have with Storybook is poor discoverability. Tags would be a huge help for that. |
@WalterWeidner This is moving forward. I shipped the tags foundations as part of 8.1 recently #26634 (documentation) Hoping to ship the interactive filtering from the RFC #25535 as part of 8.2 in the next couple months. I'm also hoping to get tags-based badges in a community addon, such as addon-badges or sidebar-statuses. There is a working gist but it needs to be incorporated into an addon that somebody maintains. |
Heya @shilman - thanks so much for your work on tags, which I can see was released - and static tags can now be filtered out :D Is interactive filtering still on the upcoming roadmap? |
@SpanishPear indeed! I implemented it in a branch but it's been blocked on design. Thankfully, we have a design now and will hopefully get it out in the coming release (8.4) which is currently being developed. Stay tuned here! |
Is your feature request related to a problem? Please describe.
Right now, there isn't a way to filter or search through filtered items in the left navigation. While searching is available to find a specific component, it searches through all available components.
Describe the solution you'd like
I would like the ability to filter AND search filtered options based on tag.
For example, the tag could be used to filter components by platform. I imagine by default, it would be set to show all components - but if I want to see just components that support Android, I could select that filter to only show me Android components. For a design system that supports different platforms, this means it's not possible to just see components that are Android, iOS, or web.
When selecting an Android-only component, the viewport should show me a view corresponding to Android. When selecting a component that only supports a web component, I should not be able to toggle my view to a mobile view.
Basically, at a glance, I should be able to see what components are supported based on platform.
Describe alternatives you've considered
Are you able to assist bring the feature to reality?
Yes
Additional context
I would love to be able to filter the left nav like this: https://backpack.github.io/components/accordion/?platform=web
The text was updated successfully, but these errors were encountered: