Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to resolve jsx files #562

Closed
rcoedo opened this issue Oct 24, 2016 · 7 comments
Closed

Unable to resolve jsx files #562

rcoedo opened this issue Oct 24, 2016 · 7 comments

Comments

@rcoedo
Copy link

rcoedo commented Oct 24, 2016

I am using storybook v2.25.1 and my webpack does not resolve jsx files. I tried adding resolve: { extensions: ['', '.js', '.jsx'] } to my .storybook/webpack.config.js file but it doesn't work.

I've seen some old issues like this one (#35), is this a regression?

thanks!

@arunoda
Copy link
Member

arunoda commented Oct 24, 2016

Is this only came after you upgrade to v2.25.1?

@arunoda
Copy link
Member

arunoda commented Oct 24, 2016

I just checked, there's no regression. I assume you've a custom webpack setup.
May be you could provide us a way to reproduce it locally. So, we could try it out.

@rcoedo
Copy link
Author

rcoedo commented Oct 24, 2016

I am using a clean create-react-app application. I installed react-storybook and renamed the Welcome and Button example components to jsx.

@arunoda
Copy link
Member

arunoda commented Oct 24, 2016

@rcoedo Let me try that.

@arunoda
Copy link
Member

arunoda commented Oct 24, 2016

Yep you are right.
Now we need to import it as Button.jsx.
I'll add a fix to that.

arunoda added a commit that referenced this issue Oct 24, 2016
arunoda added a commit that referenced this issue Oct 24, 2016
@arunoda
Copy link
Member

arunoda commented Oct 24, 2016

@rcoedo I released a new version (v2.26.0).
Could you try that out?

@arunoda arunoda reopened this Oct 24, 2016
@rcoedo
Copy link
Author

rcoedo commented Oct 24, 2016

It works now.

Thanks! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants