-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: CSS vars in theme throw errors with "Show Code" #28781
Labels
Comments
Even stranger, the error ONLY happens when basing off of the dark theme. |
pocka
added a commit
that referenced
this issue
Sep 6, 2024
This patch fixes runtime crash reported in, * <#28781> * <#25092> This patch skips color modification against theme properties if the property is color and a value is not valid color strings Polished accepts. While this wouldn't be exactly what users would expect, program is usable at least. I've added two public functions `transparentize` and `opacify` to enable internal components to access those wrapped ones. I have not added `@internal` JSDoc tag because: * that JSDoc tag is not common in this codebase, and * users would benefit from this. (I'm not proud of the number of changed files...but this is the minimal atomic change without losing context I can think of)
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When using CSS vars in the docs container theme, everything works fine until you click 'Show Code' and an error is thrown, the page goes blank.
Reproduction link
https://stackblitz.com/edit/github-lyvshn-myigje?file=.storybook%2Fpreview.tsx
Reproduction steps
System
Additional context
No response
The text was updated successfully, but these errors were encountered: