Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual/css diffing #26

Closed
jacobdeichert opened this issue Apr 3, 2016 · 11 comments
Closed

Add visual/css diffing #26

jacobdeichert opened this issue Apr 3, 2016 · 11 comments

Comments

@jacobdeichert
Copy link

Just an idea, but it would be cool to see pixel-perfect diffing of your components/stories to see how they progress over time?

PhantomCSS is a great example of what I mean.

@garris
Copy link

garris commented Apr 25, 2016

There is a probably a straightforward way to integrate BackstopJS (similar to PhantomCSS but with a workflow & UI tuned for diff-ing many states and viewport sizes). If there is some interest I could look into it.

@wyattdanger
Copy link
Contributor

I am currently using https://github.com/Galooshi/happo for visual diffing React components

@arunoda
Copy link
Member

arunoda commented Sep 1, 2016

@wyattdanger Thanks. I saw you guys use it at AirBnb.

@sylvainbannier
Copy link

@wyattdanger have you managed to reuse react storybook stories with happo ?

@bartlomn
Copy link

bartlomn commented Dec 1, 2016

Correct me if I am wrong but it looks like all the solutions linked so far use PhantomJs and therefore are suited for the CI integration. I am looking at slightly different use case - I would like to have an add-on that will add a panel with image diff for current story variant. I am looking at Resemble.js for that. Any advice / pointers / prior art / encouragements are welcome.

@garris
Copy link

garris commented Dec 1, 2016

BackstopJS is a wrapper around resemble. It manages all the necessary resources for capturing screen shots, reporting and then displaying the diffs. You can call it like a node module as well. I am too busy to do the integration work but I'd happily guide you through it.

ndelangen pushed a commit that referenced this issue Apr 5, 2017
ndelangen pushed a commit that referenced this issue Apr 5, 2017
Added a set of stories locally so its easier to test
ndelangen pushed a commit that referenced this issue Apr 11, 2017
ndelangen added a commit that referenced this issue Apr 11, 2017
Fix installation of dependencies on Windows
ndelangen added a commit that referenced this issue Apr 11, 2017
thani-sh pushed a commit that referenced this issue May 24, 2017
@ndelangen
Copy link
Member

Storybook will not build visual regression testing, because there are tools that do it that integrate very nicely into Storybook.

See:
https://percy.io/docs/clients/javascript/react-storybook
https://screener.io/

@oblador
Copy link
Member

oblador commented Jul 7, 2017

These are both paid services for web as far as I understand them. I'm working on a solution that works locally for both web, ios and android.

@ndelangen
Copy link
Member

Be sure to let us know about if when it's demo-able we can feature it on our documentation 👍

@heinzmuller
Copy link
Contributor

@oblador Give me a heads up if you need any testers/help with coding!

I looked at the suggestions @ndelangen but Percy seems very pricey, and screener will probably cost about the same.

@oblador
Copy link
Member

oblador commented Jul 8, 2017

@heinzmuller sure, DM me on twitter (@trastknast).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants