Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React-Native menu button and story title partially hidden on iPhone X #2243

Closed
danielduan opened this issue Nov 6, 2017 · 6 comments
Closed

React-Native menu button and story title partially hidden on iPhone X #2243

danielduan opened this issue Nov 6, 2017 · 6 comments
Labels
bug react-native ui

Comments

@danielduan
Copy link
Member

danielduan commented Nov 6, 2017 •
edited
Loading

screenshot from simulator:

screen shot 2017-11-06 at 12 11 02 pm

related to: #2102
@danielduan danielduan changed the title React-Native menu button hard to click on iPhone X React-Native menu button and story title partially hidden Nov 6, 2017
@ndelangen
Copy link
Member

Looks like a bug in the simulator to me, where's this dumb black blob on the top coming from?

@danielduan danielduan changed the title React-Native menu button and story title partially hidden React-Native menu button and story title partially hidden on iPhone X Nov 6, 2017
@Hypnosphi
Copy link
Member

@ndelangen https://www.apple.com/iphone-x/

@ndelangen
Copy link
Member

I feel like Apple is trolling us.

@danielduan
Copy link
Member Author

What if I told you I bought one? 😇

@ndelangen
Copy link
Member

Then I think I know who's going to fix it. /troll

danielduan added a commit that referenced this issue Nov 8, 2017
@danielduan
#2243 optimizing for iphone x
6ebb68c
@danielduan danielduan mentioned this issue Nov 8, 2017
Merged
danielduan added a commit that referenced this issue Nov 9, 2017
@danielduan
#2243 optimizing for iphone x
77b3151
Hypnosphi added a commit that referenced this issue Nov 9, 2017
@Hypnosphi
Merge pull request #2260 from storybooks/dd/iphone-x
f0588f6 
#2243 optimizing for iphone x
@ndelangen
Copy link
Member

Thanks for fixing @danielduan !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug react-native ui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danielduan @ndelangen @Hypnosphi