Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Unify the cache locations configurability by using find-cache-dir everywhere #22044

Closed
kubijo opened this issue Apr 12, 2023 · 1 comment · Fixed by #22079

Comments

@kubijo
Copy link
Contributor

kubijo commented Apr 12, 2023

Is your feature request related to a problem? Please describe

I am unifying the cache directory path for our tools and storybook is the last hard-headed one that seemingly cannot be persuaded to use it (as seen in resolve-path-in-sb-cache.ts#L6)

Describe the solution you'd like

Consider introducing some solution for this to be configurable?
You are seemingly using find-cache-dir for some cache path, which should be manipulable by CACHE_DIR env variable, but not in the linked location, which results in node_modules/.cache/storybook/{dev-server,public} being created in my workspace root (I use Yarn's PNP mechanism, so otherwise I do not have node_modules at all)…

Describe alternatives you've considered

No response

Are you able to assist to bring the feature to reality?

yes, I can

Additional context

#4665 (comment)

@kubijo
Copy link
Contributor Author

kubijo commented Apr 12, 2023

This is a follow-on the comment #4665 (comment) from @ndelangen

@kubijo kubijo changed the title [Feature Request]: [Feature Request]: Unify the cache locations configurability by using find-cache-dir everywhere Apr 12, 2023
kubijo added a commit to kubijo/storybook that referenced this issue Apr 12, 2023
kubijo added a commit to kubijo/storybook that referenced this issue Apr 12, 2023
kubijo added a commit to kubijo/storybook that referenced this issue Apr 13, 2023
@shilman shilman added core and removed needs triage labels Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants