Preact: Updating args causes a full refresh

[tmeasday]

Describe the bug
Preact version of #13913

Seems like it was originally fixed in #12221 but regressed (perhaps in preact 10?)

[KrofDrakula]

@tmeasday I thought that was intentional; I've seen this behaviour last time I was diving in the story rendering code, but wanted to preserve existing behaviour since I didn't really know whether it was intentional or not.

[tmeasday]

Hey @KrofDrakula. I'm not quite sure what was intended by who/when but the "correct" behaviour in Storybook is that the story/component should remount when you change story (or a couple other events) but should re-renderer without remounting when you change args or globals.

[KrofDrakula]

@tmeasday Yeah, that makes much more sense to me; it always bothered me that it completely unmounted the components when changing any parameter.

[TiborUdvari]

I'm getting this issue with

    "preact": "^10.24.3",
    "storybook": "^8.4.2",

I see the code you changed now lives here:

storybook/code/core/template/stories/rendering.stories.ts

Line 64 in 860e63e

if (['web-components', 'html', 'preact'].includes(globalThis.storybookRenderer)) {

But it does not include vue3 or svelte anymore, so maybe there were some changes in the meantime that broke this functionality.

I would like to help more, but I'm unfamiliar with the codebase.

[tmeasday]

@TiborUdvari

But it does not include vue3 or svelte anymore, so maybe there were some changes in the meantime that broke this functionality.

That code was disabling the test in vue3/svelte, so the removal of them from the list means they were fixed. You can see the vue fix in this PR:

#20712