Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-storybook - CMD icon breaks in UI #168

Closed
kevinSuttle opened this issue May 5, 2016 · 9 comments
Closed

build-storybook - CMD icon breaks in UI #168

kevinSuttle opened this issue May 5, 2016 · 9 comments
Labels
bug

Comments

@kevinSuttle
Copy link
Contributor

screen shot 2016-05-05 at 2 18 50 pm
@arunoda arunoda added the bug label May 6, 2016
@arunoda
Copy link
Member

arunoda commented May 6, 2016

Oops. What's this OS?

@arunoda
Copy link
Member

arunoda commented May 6, 2016

@thinkholic Could you add a SVG icon to this button?

@kevinSuttle
Copy link
Contributor Author

OSX 10.4, Chrome stable. Latest.

heimdallrj added a commit that referenced this issue May 6, 2016
@heimdallrj
Fix for #168
d91e714
arunoda pushed a commit that referenced this issue May 6, 2016
@thinkholic @arunoda
Fix for #168 (#170)
bc13102
@arunoda
Copy link
Member

arunoda commented May 6, 2016

@kevinSuttle We released a new version(v1.21.0) with a potential fix. Could you check that?

@kevinSuttle
Copy link
Contributor Author

kevinSuttle commented May 7, 2016 •
edited
Loading

Nope. Unfortunately, no fix.

screen shot 2016-05-07 at 1 45 13 pm

Something is happening in the build where the odd characters (i.e. ⌘) are being printed out.

screen shot 2016-05-07 at 2 07 16 pm

Maybe try a :before CSS pseudo-element: \2318

@arunoda
Copy link
Member

arunoda commented May 9, 2016

@mnmtanish @thinkholic Could you guys try @kevinSuttle's suggestions. I'm kind a noob in this area.

timkindberg pushed a commit to timkindberg/react-storybook that referenced this issue May 10, 2016
@thinkholic
Fix for storybookjs#168 (storybookjs#170)
bbabd45
@thani-sh
Copy link
Contributor

Hi @kevinSuttle
I think #215 is related. Can you try v1.28.1 I'm sure it will fix the issue.

CC: @arunoda @thinkholic

@kevinSuttle
Copy link
Contributor Author

Woot! Seems fixed! Thanks gents!

@kevinSuttle
Copy link
Contributor Author

screen shot 2016-05-25 at 9 34 20 pm

screen shot 2016-05-25 at 9 34 28 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arunoda @kevinSuttle @thani-sh