Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not working in Firefox #143

Closed
uyeong opened this issue Apr 25, 2016 · 6 comments
Closed

not working in Firefox #143

uyeong opened this issue Apr 25, 2016 · 6 comments
Labels

Comments

@uyeong
Copy link

uyeong commented Apr 25, 2016

ReferenceError: identity is not defined

2016-04-25 2 32 06

Version is 45.0.2

@thani-sh
Copy link
Contributor

Hi @uyeong

I'm also getting the same error.

NOTE:
It works fine with the static build so most probably this must be an HMR issue.

screen shot 2016-04-25 at 11 37 35 am

@arunoda arunoda added the bug label Apr 25, 2016
@thani-sh
Copy link
Contributor

thani-sh commented Apr 25, 2016

#144 fixes this error

NOTE:
It's not an HMR issue. The stack-source-map module didn't work with Firefox

@thani-sh
Copy link
Contributor

Hi @uyeong
Just released a new version v1.17.2 with the fix.
Thanks for reporting

@mquandalle
Copy link

I also encountered this error and I didn’t understand it was specific to Firefox and I thought Storybook was just plain broken. This is a pretty bad first experience, do you have any plan to configure a CI tool run the tests in the different major browsers?

@thani-sh
Copy link
Contributor

Yes I agree. Thanks for checking it out again. We're going to refactor the storybook to use Mantra. We'll setup a good CI for cross browser tests as soon as it's done.

@arunoda
Copy link
Member

arunoda commented May 10, 2016

Closing this since we've fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants