Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recording actions causes stories to unmount and remount #136

Closed
wyattdanger opened this issue Apr 22, 2016 · 6 comments
Closed

Recording actions causes stories to unmount and remount #136

wyattdanger opened this issue Apr 22, 2016 · 6 comments

Comments

@wyattdanger
Copy link
Contributor

wyattdanger commented Apr 22, 2016

I have a story that displays 259 Icons. Whenever I record an action, it appears as if all of the components are unmounted from the DOM and remounted, resulting in 259 calls to each of componentWillUnmount, componentWillMount, and componentDidMount. Here is a screenshot from the console: (the timer measures from componentWillMount to componentDidMount of a component which contains the story).

screen shot 2016-04-21 at 6 04 48 pm

This results in a clunky story, because each time I click on an Icon (hoping to record the icon's name in an action), the page freezes up for over a second. Would be great to avoid unmounting and remounting each time.

@arunoda
Copy link
Member

arunoda commented Apr 22, 2016

We fixed this. Could you try to use the latest version?

@wyattdanger
Copy link
Contributor Author

I still see the issue on 1.17.1, (I should have mentioned that in the original issue).

@arunoda
Copy link
Member

arunoda commented Apr 22, 2016

Okay. Then is a problem. Could you send me a sample app with this issue.

We will work on it test it.

@wyattdanger
Copy link
Contributor Author

I'll work on an example, thank you

@arunoda
Copy link
Member

arunoda commented Apr 23, 2016

Great.

@wyattdanger
Copy link
Contributor Author

Closing until I have a good example

ndelangen pushed a commit that referenced this issue Apr 11, 2017
Update text on show info button from "?" to "Show info"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants