Typescript extended props not show v6 #12129

Quadriphobs1 · 2020-08-19T09:57:56Z

Describe the bug
Define typescript props for component with extending other props, doesn't show the extended props.

For example a component with

interface TProps extends ComponentPropsWithoutRef<"input"> {
  label?: string;
  state?: InputState;
  helper?: string | React.ReactElement;
}

export const TextField = forwardRef(
  (
    { label, placeholder, state, helper, ...rest }: TProps,
    ref: Ref<HTMLInputElement>
  ) => (
    ...
  )
);

Produces the following

Expected behavior
Its suppose to show all the props valid for the component such as type, max, min e.t.c

System:

Environment Info:
  Binaries:
    Node: 14.2.0 - ~/.nvm/versions/node/v14.2.0/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.7 - ~/.nvm/versions/node/v14.2.0/bin/npm
  Browsers:
    Chrome: 84.0.4147.125
    Firefox: 77.0.1
    Safari: 13.1.2
  npmPackages:
    @storybook/addon-docs: ^6.0.6 => 6.0.6 
    @storybook/addon-essentials: ^6.0.6 => 6.0.6 
    @storybook/addon-knobs: ^6.0.6 => 6.0.6 
    @storybook/addon-links: ^6.0.6 => 6.0.6 
    @storybook/addon-notes: ^5.3.19 => 5.3.19 
    @storybook/addon-storysource: ^6.0.6 => 6.0.6 
    @storybook/addon-viewport: ^6.0.6 => 6.0.6 
    @storybook/addons: ^6.0.6 => 6.0.6 
    @storybook/preset-create-react-app: ^3.1.4 => 3.1.4 
    @storybook/react: ^6.0.6 => 6.0.6

The text was updated successfully, but these errors were encountered:

petermikitsh · 2020-08-19T15:10:49Z

Try adding this to main.js:

  typescript: {
    reactDocgen: 'react-docgen-typescript',
    reactDocgenTypescriptOptions: {
      compilerOptions: {
        allowSyntheticDefaultImports: false,
        esModuleInterop: false,
      },
    }
  }

shilman · 2020-08-19T15:13:05Z

@petermikitsh should either of those options be made default?

Quadriphobs1 · 2020-08-19T15:19:14Z

It seems like just having this works, so it must some misconfiguration internally

typescript: {
    reactDocgen: 'react-docgen-typescript',
    reactDocgenTypescriptOptions: {
    }
  }

stale · 2020-09-20T05:07:31Z

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

shilman · 2020-09-22T01:59:30Z

These are the defaults. It's probably because it's excluding node_modules by default:

https://github.com/storybookjs/storybook/blob/next/lib/core/src/server/config/defaults.js#L4-L8

I think excluding node_modules is the right default, at least until we have something like #9110

Perhaps we need to make it easier to enable that, as a flag? Or just improve the documentation? What do you think?

awkale · 2020-10-01T21:32:27Z

Try adding this to main.js:

  typescript: {
    reactDocgen: 'react-docgen-typescript',
    reactDocgenTypescriptOptions: {
      compilerOptions: {
        allowSyntheticDefaultImports: false,
        esModuleInterop: false,
      },
    }
  }

Does the above go inside of
module.exports = {}

I don't see any props that have been extended.

shilman · 2020-10-02T05:23:15Z

@awkale yes

jonniebigodes · 2020-10-20T22:11:30Z

A recent pull request #12841 was created to adjust the documentation and include a bit more of context regarding the issue.

Let me know if you're ok with it and any additional feedback is welcome.

Stay safe

Chore: update documentation to address issue #12129

stale · 2020-12-25T21:55:31Z

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

sidneypp · 2021-03-13T18:19:45Z

I'm having the same problem right now, using the material ui, is anyone working on it?

natac13 · 2021-03-23T20:05:40Z

Try adding this to main.js:

  typescript: {
    reactDocgen: 'react-docgen-typescript',
    reactDocgenTypescriptOptions: {
      compilerOptions: {
        allowSyntheticDefaultImports: false,
        esModuleInterop: false,
      },
    }
  }

This suggest is working for me, however it exposes every HTML prop as well, making the storybook ui unusable since each component now has close to 300 props.
Is there a way to stop the extending at the MUI package and no further??

shilman · 2021-03-23T21:13:27Z

@natac13 the propFilter config option is a function, so you should be able to do something tricky there to get only the props you want

ptoly · 2021-05-04T12:33:30Z

I attempted to get the props using the propFilter but still doesn't work.

propFilter: (prop) => {
        return prop.parent
            ? /@material-ui/.test(prop.parent.fileName) ||
            !/node_modules/.test(prop.parent.fileName)
            : true;
      },

andresdsep · 2021-05-06T01:40:39Z

It seems like just having this works, so it must some misconfiguration internally
typescript: {
    reactDocgen: 'react-docgen-typescript',
    reactDocgenTypescriptOptions: {
    }
  }

Personally, it only seemed to work for me with this configuration. Having the additional two booleans in there would break it. Unfortunately, having this new config brings in the props I wanted, but it wrecks some other controls I have (such as limiting another prop to a couple of options).

KasimAhmic · 2021-08-23T19:30:39Z

Currently we're using Storybook 6.2.9 with Material UI 4.12.0 and the below configuration works flawlessly for us. It renders all the MUI props properly and ignores all the default HTML props. The two key changes for us were the propFilter and allowSyntheticDefaultImports options. Hope this helps some of you!

module.exports = {
  stories: ["../src/**/*.stories.@(ts|tsx|js|jsx)"],
  addons: ["@storybook/addon-links", "@storybook/addon-essentials"],
  typescript: {
    check: true,
    reactDocgen: "react-docgen-typescript",
    reactDocgenTypescriptOptions: {
      shouldExtractLiteralValuesFromEnum: true,
      propFilter: (prop) =>
        prop.parent
          ? /@material-ui/.test(prop.parent.fileName) || !/node_modules/.test(prop.parent.fileName)
          : true,
      compilerOptions: {
        allowSyntheticDefaultImports: false,
      },
    },
  },
}

mstosio · 2021-09-03T15:05:43Z

None of those works for me, some props are extended and created correctly. For example for Button, but for a lot of components I'm getting some useless garbage and not correct props for example Alert. Any solution for this?

mstosio · 2021-09-17T15:15:23Z

Maybe it a little bit tricky but I found temporary solution to generate only material ui props and ignore all of HTML props.

module.exports = {
  stories: ["../src/**/*.stories.tsx"],
  // Add any Storybook addons you want here: https://storybook.js.org/addons/
  addons: ["@storybook/addon-links", "@storybook/addon-essentials"],
  typescript: {
    check: false,
    checkOptions: {},
    reactDocgen: "react-docgen-typescript",
    reactDocgenTypescriptOptions: {
      shouldExtractLiteralValuesFromEnum: true,
      propFilter: (prop) => {
        return prop.parent
            ?  prop.parent.name !== 'DOMAttributes' && prop.parent.name !== 'HTMLAttributes' && prop.parent.name !== 'AriaAttributes'
            : true;
      },
    },
  },
}

lucasluca · 2021-10-20T20:40:58Z

Having the same problem here

bastiW · 2021-11-29T20:44:08Z

@mstosio

How does your button story look like?

I tried with your example and the following story.

But the args table is still not generated (it works for non mui components)

import React from 'react';
import {ComponentStory, ComponentMeta } from '@storybook/react';

import {Button} from "@mui/material";

export default {
  title: 'Components/Button',
  component: Button,
  argTypes: {
    variant: {
      options: ['contained', 'outlined'],
      control: { type: 'radio' },
    },
  },
} as ComponentMeta<typeof Button>;

const Template: ComponentStory<typeof Button> = (args) => <Button {...args} >My Button</Button>;

export const PrimaryButton = Template.bind({});
PrimaryButton.args = {
  variant: 'outlined'
};

dirkvanvugt · 2021-12-02T08:42:03Z

The configuration from @mstosio works for me.

I however also need to create named exports for mui components instead of a default export (this is mentioned on the Storybook TypeScript docs as well).

So I create a file

import Button, { ButtonProps } from '@mui/material/Button';

export const MyButton = ({ ...props }: ButtonProps) => <Button {...props} />;

And then import the MyButton in the story. I'm using the same setup as @bastiW for writing stories. Now I get the correct props displayed in the Docs tab.

I hope this helps.

mstosio · 2021-12-02T09:02:34Z

@mstosio

How does your button story look like?

I tried with your example and the following story.

But the args table is still not generated (it works for non mui components)

import React from 'react';
import {ComponentStory, ComponentMeta } from '@storybook/react';

import {Button} from "@mui/material";

export default {
  title: 'Components/Button',
  component: Button,
  argTypes: {
    variant: {
      options: ['contained', 'outlined'],
      control: { type: 'radio' },
    },
  },
} as ComponentMeta<typeof Button>;

const Template: ComponentStory<typeof Button> = (args) => <Button {...args} >My Button</Button>;

export const PrimaryButton = Template.bind({});
PrimaryButton.args = {
  variant: 'outlined'
};

import Button from './Button'
import { LoadingButtonProps as ButtonProps } from '@mui/lab';
import { Story, Meta } from '@storybook/react';

export default {
    component: Button,
    title: 'Inputs/Button',
} as Meta;

const Template: Story<ButtonProps> = (args: ButtonProps) => <Button {...args} />;

export const PrimaryButton = Template.bind({});


PrimaryButton.args = {
    children: 'Button',
    variant: 'contained',
    color: 'primary',
};

Try to import ButtonProps from Material UI. I think you are missing this part.

stale · 2022-01-09T14:16:40Z

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

krishnans · 2022-04-26T08:55:08Z

did anyone tried this in Mui 5. I have added additional properties in theme like below

declare module '@mui/material/styles' {

    interface TypographyVariants {
      body14: React.CSSProperties;
      body14b: React.CSSProperties;
    }
 
    // allow configuration using `createTheme`
    interface TypographyVariantsOptions {
      body14?: React.CSSProperties;
      body14b?: React.CSSProperties;
    }
  }
  
  // Update the Typography's variant prop options
  declare module '@mui/material/Typography' {
    interface TypographyPropsVariantOverrides {
      body14: true;
      body14b: true;
    }
  }

I can see and use the additional variants through the code, but not in storybook

I am using
Node: 14.7.0
npm: 8.0.0
yarn: 1.21.1

React: 17
storybook: 6.5.0-alpha

VietNguyenR · 2022-05-26T02:47:22Z

Maybe it a little bit tricky but I found temporary solution to generate only material ui props and ignore all of HTML props.

module.exports = {
  stories: ["../src/**/*.stories.tsx"],
  // Add any Storybook addons you want here: https://storybook.js.org/addons/
  addons: ["@storybook/addon-links", "@storybook/addon-essentials"],
  typescript: {
    check: false,
    checkOptions: {},
    reactDocgen: "react-docgen-typescript",
    reactDocgenTypescriptOptions: {
      shouldExtractLiteralValuesFromEnum: true,
      propFilter: (prop) => {
        return prop.parent
            ?  prop.parent.name !== 'DOMAttributes' && prop.parent.name !== 'HTMLAttributes' && prop.parent.name !== 'AriaAttributes'
            : true;
      },
    },
  },
}

Nice one and works fine, thanks a lot. Do we have an official solution now?

ivanbanov · 2022-06-14T11:38:50Z

Even though the code forces savePropValueAsString: true

storybook/app/react/src/server/framework-preset-react-docs.ts

Line 56 in 1ba5e3d

savePropValueAsString: true,

It didn't work out of the box for me and I needed to add it manually

module.exports = {
  typescript: {
    // https://github.com/storybookjs/storybook/issues/12129#issuecomment-921878013
    reactDocgen: "react-docgen-typescript",
    reactDocgenTypescriptOptions: {
      shouldExtractLiteralValuesFromEnum: true,
      savePropValueAsString: true, // <--- here
      propFilter: prop => true /* your filter */
    },
  },
}

ivanbanov · 2022-06-14T13:19:50Z

Oh actually it was shouldRemoveUndefinedFromOptional

yarinsa · 2022-11-16T11:49:51Z

If anyone is looking for a solution working with ant-design & react-docgen-typescript. The following solves the issue:

In the component level, redeclare the Props even if empty, "redeclare" the component so docgen can infer the propTypes (see example)

// Alert.tsx
import type { AlertProps as AntAlertProps } from 'antd/es/alert';
import AntAlert from 'antd/es/alert';

import { FC } from 'react';

export interface Props extends AntAlertProps {}

const Alert: FC<Props> = ({ ...props }: Props) => {
  return <AntAlert {...props} />;
};

export default Alert;
export type { Props as AlertProps };

Add the following configuration to filter in antd props (node_modules is filtered out by default)

 reactDocgen: 'react-docgen-typescript',
    reactDocgenTypescriptOptions: {
      // By default react-doc-gen-typescript filters node_modules type, this includes antd types
      tsconfigPath: '../tsconfig.json',
      propFilter: (prop: any) => {
        const res = /antd/.test(prop.parent?.fileName) || !/node_modules/.test(prop.parent?.fileName);
        return prop.parent ? res : true;
      },
      // The following 2 options turns string types into string literals and allows
      shouldExtractLiteralValuesFromEnum: true,
      savePropValueAsString: true,
      shouldRemoveUndefinedFromOptional: true,
    },

idanziv · 2023-02-15T11:41:01Z

I am having a similar problem to @krishnans with my own extended MUI 5 Theme
I extended my Theme as instructed in the MUI docs and can use the custom color in the code but the dropdown control in Storybook doesn't show the color I added as a pickable value.

I extended my theme like this:

import '@mui/material/styles';
import '@mui/material/Button';

declare module '@mui/material/styles/createPalette' {
    interface Palette {
        myCustomColor: Palette['primary'];
    }
    interface PaletteOptions {
        myCustomColor?: PaletteOptions['primary'];
    }
}

declare module '@mui/material/Button/Button' {
    interface ButtonPropsColorOverrides {
        myCustomColor: true;
    }
}

My Storybook main.js file looks like this:

module.exports = {
  stories: ["../src/**/*.stories.mdx", "../src/**/*.stories.@(js|jsx|ts|tsx)"],
  addons: [
    "@storybook/addon-links",
    "@storybook/addon-essentials",
    "@storybook/addon-interactions",
  ],
  framework: "@storybook/react",
  core: {
    builder: "@storybook/builder-webpack5",
  },
  typescript: {
    check: false,
    checkOptions: {},
    reactDocgen: "react-docgen-typescript",
    reactDocgenTypescriptOptions: {
      allowSyntheticDefaultImports: false, // speeds up storybook build time
      esModuleInterop: false, // speeds up storybook build time
      shouldExtractValuesFromUnion: true,
      shouldExtractLiteralValuesFromEnum: true, // makes union prop types like variant and size appear as select controls
      shouldRemoveUndefinedFromOptional: true, // makes string and boolean types that can be undefined appear as inputs and switches
      savePropValueAsString: true,
      propFilter: (prop) =>
        prop.parent ? !/node_modules/.test(prop.parent.fileName) : true,
      skipPropsWithoutDoc: false,
      skipChildrenPropWithoutDoc: false,
      tsconfigPath: '../tsconfig.json',
    },
  },
};

And my Button.tsx component file looks like this:

import * as React from "react";
import { Button as MaterialButton } from "@mui/material";
import type { ButtonProps as MuiButtonProps } from "@mui/material";

export interface ButtonProps extends MuiButtonProps {
  label: string;
  onClick: React.MouseEventHandler<HTMLButtonElement>;
}

export const Button: React.FC<ButtonProps> = (props: ButtonProps) => {
  const { label } = props;
  return <MaterialButton {...props}>{label}</MaterialButton>;
};

With this result, where myCustomColor is not shown in the color dropdown options:

I am using:
node: 18.14.0
npm: 9.3.1
react: 18.2.0
typescript: 4.9.5
@storybook/react: 6.5.16

shubham799 · 2023-03-27T20:32:10Z

Any luck? i am still not getting all MUI props in storybook UI.

idanziv · 2023-03-28T11:50:20Z

@shubham799 I kinda worked around this by using SB argTypes and defining the needed props and possible values explicitly.
It's not the best but seeing as there's no update yet it worked for our usecase.

Referring to the color problem above, this is how we solved it:

// colors.ts
import { theme } from './theme';

const muiNonColorValues = [
  'mode',
  'common',
  'grey', // this is not a color even though it has the name of one :shrug:
  'contrastThreshold',
  'getContrastText',
  'augmentColor',
  'tonalOffset',
  'text',
  'divider',
  'background',
  'action',
];

export const colors = Object.keys(theme.palette).filter(
  (colorKey) => !muiNonColorValues.includes(colorKey),
);

// Button.stories.tsx

import type { ComponentStory, ComponentMeta } from '@storybook/react';

import { Button } from './Button';
import { colors } from '../../styles/colors';

export default {
  /* 👇 The title prop is optional.
   * See https://storybook.js.org/docs/react/configure/overview#configure-story-loading
   * to learn how to generate automatic titles
   */
  title: 'Button',
  component: Button,
  argTypes: {
    color: {
      options: colors,
      control: 'select',
      description:
        'The color of the component. It supports both default MUI colors and custom colors defined in our Theme',
      table: {
        type: null,
      },
    },
  },
} as ComponentMeta<typeof Button>;

// ...our stories

CHE1RON · 2023-04-24T11:26:43Z

This still happens and since there's no way determining the cause, this is rather frustrating. I checked with all configurations shown above, and nothing works as expected (1) props are shown, 2) with their correct control types and 3) possible values) - since MUI is (by far) the largest React component library, this is something really worth being investigated / documented, because the docs don't work 😭

kylegach · 2023-05-03T22:04:00Z

@integrayshaun — Mind looking into this? It appears the MUI recipe doesn't work for all setups?

If someone here can provide a simplified reproduction (https://storybook.new is great for this), that would be a big help. Thanks!

ShaunEvening · 2023-05-04T19:05:32Z

Hey folks, here's an updated example repo for the material UI recipe to help you on your way.

If you have more questions, let me know and i'll work on making it clearer

https://stackblitz.com/edit/github-ju9knk?file=.storybook/preview.ts

d9k · 2023-05-21T04:14:39Z

My propFilter declaration:

    reactDocgenTypescriptOptions: {
      shouldExtractLiteralValuesFromEnum: true,
      propFilter: (prop) => {
        if (!prop.parent?.name) {
          return true;
        }

        if (['value', 'onChange'].includes(prop.name)) {
          return true;
        }

        if ([
          'AriaAttributes',
          'AnchorHTMLAttributes',
          'Attributes',
          'ButtonHTMLAttributes',
          'ClassAttributes',
          'DOMAttributes',
          'HTMLAttributes',
          'InputHTMLAttributes'
        ].includes(prop.parent.name)) {
          return false;
        }

        if (/node_modules\/typescript/.test(prop.parent.fileName)) {
          return false;
        }

        //if (/node_modules/.test(prop.parent.fileName)) {
        //  console.log('__TEST__', prop.parent.name);
        //  console.log('__TEST__2__', prop);
        //}

        return true;
      },
    },

lucianobarauna · 2023-08-09T21:05:54Z

@yarinsa thanks for solution

developerdanwu · 2024-01-03T11:51:15Z

I am having a similar problem to @krishnans with my own extended MUI 5 Theme I extended my Theme as instructed in the MUI docs and can use the custom color in the code but the dropdown control in Storybook doesn't show the color I added as a pickable value.

I extended my theme like this:

import '@mui/material/styles';
import '@mui/material/Button';

declare module '@mui/material/styles/createPalette' {
    interface Palette {
        myCustomColor: Palette['primary'];
    }
    interface PaletteOptions {
        myCustomColor?: PaletteOptions['primary'];
    }
}

declare module '@mui/material/Button/Button' {
    interface ButtonPropsColorOverrides {
        myCustomColor: true;
    }
}

My Storybook main.js file looks like this:

module.exports = {
  stories: ["../src/**/*.stories.mdx", "../src/**/*.stories.@(js|jsx|ts|tsx)"],
  addons: [
    "@storybook/addon-links",
    "@storybook/addon-essentials",
    "@storybook/addon-interactions",
  ],
  framework: "@storybook/react",
  core: {
    builder: "@storybook/builder-webpack5",
  },
  typescript: {
    check: false,
    checkOptions: {},
    reactDocgen: "react-docgen-typescript",
    reactDocgenTypescriptOptions: {
      allowSyntheticDefaultImports: false, // speeds up storybook build time
      esModuleInterop: false, // speeds up storybook build time
      shouldExtractValuesFromUnion: true,
      shouldExtractLiteralValuesFromEnum: true, // makes union prop types like variant and size appear as select controls
      shouldRemoveUndefinedFromOptional: true, // makes string and boolean types that can be undefined appear as inputs and switches
      savePropValueAsString: true,
      propFilter: (prop) =>
        prop.parent ? !/node_modules/.test(prop.parent.fileName) : true,
      skipPropsWithoutDoc: false,
      skipChildrenPropWithoutDoc: false,
      tsconfigPath: '../tsconfig.json',
    },
  },
};

And my Button.tsx component file looks like this:

import * as React from "react";
import { Button as MaterialButton } from "@mui/material";
import type { ButtonProps as MuiButtonProps } from "@mui/material";

export interface ButtonProps extends MuiButtonProps {
  label: string;
  onClick: React.MouseEventHandler<HTMLButtonElement>;
}

export const Button: React.FC<ButtonProps> = (props: ButtonProps) => {
  const { label } = props;
  return <MaterialButton {...props}>{label}</MaterialButton>;
};

With this result, where myCustomColor is not shown in the color dropdown options:

I am using: node: 18.14.0 npm: 9.3.1 react: 18.2.0 typescript: 4.9.5 @storybook/react: 6.5.16

I tried using this and it works for module augmentation. The key is the include option below. My declaration file is named styles.d.ts. You have to include it for storybook to take into account the augmented styles. Hope it helps someone

const config: StorybookConfig = {
  typescript: {
    check: false,
    reactDocgen: 'react-docgen-typescript',
    reactDocgenTypescriptOptions: {
      include: ['**/**.tsx', 'src/themes/styles.d.ts'],
      shouldExtractLiteralValuesFromEnum: true,
      skipChildrenPropWithoutDoc: false,
      shouldRemoveUndefinedFromOptional: true,
      tsconfigPath: './tsconfig.json',
      compilerOptions: {
        allowSyntheticDefaultImports: false,
        esModuleInterop: false,
      },
      propFilter: (prop) =>
        prop.parent
          ? /@material-ui/.test(prop.parent.fileName) ||
            !/node_modules/.test(prop.parent.fileName)
          : true,
    },
  },
...
};

CHE1RON · 2024-01-03T14:27:31Z

I'm still struggling to get it working with @mantine packages .. any ideas, guys? 🙏

ShaunEvening · 2024-01-03T14:32:11Z

@CHE1RON,

Can you provide me a repro with @mantine for investigation?

adirzoari · 2024-03-07T23:22:01Z

reactDocgen: "react-docgen-typescript",
reactDocgenTypescriptOptions: {
shouldExtractLiteralValuesFromEnum: true,
propFilter: (prop) => {
return prop.parent
? prop.parent.name !== 'DOMAttributes' && prop.parent.name !== 'HTMLAttributes' && prop.parent.name !== 'AriaAttributes'
: true;
},
},

},

mstosio

@mstosio thanks. It helps me, but it adds an undefined value each time. Is there a solution to prevent this undefined value?
@developerdanwu @ivanbanov @andresdsep @Quadriphobs1 @dirkvanvugt

developerdanwu · 2024-03-08T00:54:30Z

reactDocgen: "react-docgen-typescript",
reactDocgenTypescriptOptions: {
shouldExtractLiteralValuesFromEnum: true,
propFilter: (prop) => {
return prop.parent
? prop.parent.name !== 'DOMAttributes' && prop.parent.name !== 'HTMLAttributes' && prop.parent.name !== 'AriaAttributes'
: true;
},
},

> },

mstosio

@mstosio thanks. It helps me, but it adds an undefined value each time. Is there a solution to prevent this undefined value? @developerdanwu @ivanbanov @andresdsep @Quadriphobs1 @dirkvanvugt

@adirzoari try add shouldRemoveUndefinedFromOptional: true to ur config

shilman added block: argstable question / support typescript labels Aug 26, 2020

stale bot added the inactive label Sep 20, 2020

stale bot removed the inactive label Sep 22, 2020

shilman added the documentation label Sep 25, 2020

shilman mentioned this issue Sep 25, 2020

Material UI interface props not showing in Docs #12508

Closed

jonniebigodes mentioned this issue Oct 20, 2020

Chore: update documentation to address issue #12129 #12841

Merged

shilman added a commit that referenced this issue Oct 21, 2020

Merge pull request #12841 from storybookjs/fix_issue_12129

5d7d205

Chore: update documentation to address issue #12129

shilman added a commit that referenced this issue Oct 22, 2020

Merge pull request #12841 from storybookjs/fix_issue_12129

fc82a55

Chore: update documentation to address issue #12129

stale bot added the inactive label Dec 25, 2020

stale bot removed the inactive label Mar 13, 2021

stale bot added the inactive label Jan 9, 2022

stale bot removed the inactive label Apr 26, 2022

kylegach added this to Learning Team Apr 24, 2023

kylegach removed this from Learning Team May 8, 2023

ignromanov mentioned this issue Oct 21, 2024

Implement curve-ui-kit package to represent Figma design curvefi/curve-frontend#400

Merged

Typescript extended props not show v6 #12129

Typescript extended props not show v6 #12129

Comments

Quadriphobs1 commented Aug 19, 2020

petermikitsh commented Aug 19, 2020

shilman commented Aug 19, 2020 • edited Loading

Quadriphobs1 commented Aug 19, 2020 • edited Loading

stale bot commented Sep 20, 2020

shilman commented Sep 22, 2020 • edited Loading

awkale commented Oct 1, 2020

shilman commented Oct 2, 2020

jonniebigodes commented Oct 20, 2020

stale bot commented Dec 25, 2020

sidneypp commented Mar 13, 2021

natac13 commented Mar 23, 2021

shilman commented Mar 23, 2021

ptoly commented May 4, 2021 • edited Loading

andresdsep commented May 6, 2021

KasimAhmic commented Aug 23, 2021

mstosio commented Sep 3, 2021

mstosio commented Sep 17, 2021

lucasluca commented Oct 20, 2021

bastiW commented Nov 29, 2021

dirkvanvugt commented Dec 2, 2021

mstosio commented Dec 2, 2021

stale bot commented Jan 9, 2022

krishnans commented Apr 26, 2022

VietNguyenR commented May 26, 2022

ivanbanov commented Jun 14, 2022

ivanbanov commented Jun 14, 2022

yarinsa commented Nov 16, 2022

idanziv commented Feb 15, 2023

shubham799 commented Mar 27, 2023 • edited Loading

idanziv commented Mar 28, 2023

CHE1RON commented Apr 24, 2023

kylegach commented May 3, 2023

ShaunEvening commented May 4, 2023

d9k commented May 21, 2023 • edited Loading

lucianobarauna commented Aug 9, 2023

developerdanwu commented Jan 3, 2024

CHE1RON commented Jan 3, 2024

ShaunEvening commented Jan 3, 2024

adirzoari commented Mar 7, 2024

developerdanwu commented Mar 8, 2024

shilman commented Aug 19, 2020 •

edited

Loading

Quadriphobs1 commented Aug 19, 2020 •

edited

Loading

shilman commented Sep 22, 2020 •

edited

Loading

ptoly commented May 4, 2021 •

edited

Loading

shubham799 commented Mar 27, 2023 •

edited

Loading

d9k commented May 21, 2023 •

edited

Loading