Skip to content

Commit

Permalink
Merge branch 'next' into shilman/vue-cli-repro-templates
Browse files Browse the repository at this point in the history
  • Loading branch information
shilman authored Sep 16, 2022
2 parents 18709fc + 30e9e02 commit e957951
Show file tree
Hide file tree
Showing 151 changed files with 977 additions and 795 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ jobs:
executor:
class: medium+
name: sb_node_14_browsers
parallelism: 15
parallelism: 14
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.old.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ Then run `yarn cypress open` if you want to see the tests run in the UI, or `yar

The best way to help figure out an issue you are having is to produce a minimal reproduction against the `main` branch.

A good way to do that is using the example `cra-kitchen-sink` app embedded in this repository:
A good way to do that is using the example `official-storybook` app embedded in this repository:

```sh
# Download and build this repository:
Expand All @@ -157,7 +157,7 @@ yarn
yarn bootstrap --core

# make changes to try and reproduce the problem, such as adding components + stories
cd examples/cra-kitchen-sink
cd examples/official-storybook
yarn storybook

# see if you can see the problem, if so, commit it:
Expand Down
1 change: 0 additions & 1 deletion code/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ package-lock.json
storybook-static
integration/__image_snapshots__/__diff_output__
.jest-test-results.json
/examples/cra-kitchen-sink/src/__image_snapshots__/__diff_output__/
lib/*.jar
lib/**/dll
/false
Expand Down
2 changes: 1 addition & 1 deletion code/addons/a11y/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"*.d.ts"
],
"scripts": {
"check": "tsc --noEmit",
"check": "../../../scripts/node_modules/.bin/tsc --noEmit",
"prep": "../../../scripts/prepare/bundle.ts"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/actions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"*.d.ts"
],
"scripts": {
"check": "tsc --noEmit",
"check": "../../../scripts/node_modules/.bin/tsc --noEmit",
"prep": "node ../../../scripts/prepare.js"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/backgrounds/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"*.d.ts"
],
"scripts": {
"check": "tsc --noEmit",
"check": "../../../scripts/node_modules/.bin/tsc --noEmit",
"prep": "../../../scripts/prepare/bundle.ts"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/controls/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"*.d.ts"
],
"scripts": {
"check": "tsc --noEmit",
"check": "../../../scripts/node_modules/.bin/tsc --noEmit",
"prep": "../../../scripts/prepare/bundle.ts"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"!__testfixtures__"
],
"scripts": {
"check": "tsc --noEmit",
"check": "../../../scripts/node_modules/.bin/tsc --noEmit",
"prep": "node ../../../scripts/prepare.js"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/essentials/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"README.md"
],
"scripts": {
"check": "tsc --noEmit",
"check": "../../../scripts/node_modules/.bin/tsc --noEmit",
"prep": "node ../../../scripts/prepare.js"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/highlight/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"*.d.ts"
],
"scripts": {
"check": "tsc --noEmit",
"check": "../../../scripts/node_modules/.bin/tsc --noEmit",
"prep": "node ../../../scripts/prepare.js"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/interactions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"*.d.ts"
],
"scripts": {
"check": "tsc --noEmit",
"check": "../../../scripts/node_modules/.bin/tsc --noEmit",
"prep": "../../../scripts/prepare/bundle.ts"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/jest/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"*.d.ts"
],
"scripts": {
"check": "tsc --noEmit",
"check": "../../../scripts/node_modules/.bin/tsc --noEmit",
"prep": "../../../scripts/prepare/bundle.ts"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/links/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"*.d.ts"
],
"scripts": {
"check": "tsc --noEmit",
"check": "../../../scripts/node_modules/.bin/tsc --noEmit",
"prep": "../../../scripts/prepare/bundle.ts"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/measure/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"*.d.ts"
],
"scripts": {
"check": "tsc --noEmit",
"check": "../../../scripts/node_modules/.bin/tsc --noEmit",
"prep": "../../../scripts/prepare/bundle.ts"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/outline/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"*.d.ts"
],
"scripts": {
"check": "tsc --noEmit",
"check": "../../../scripts/node_modules/.bin/tsc --noEmit",
"prep": "../../../scripts/prepare/bundle.ts"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/storysource/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"*.d.ts"
],
"scripts": {
"check": "tsc --noEmit",
"check": "../../../scripts/node_modules/.bin/tsc --noEmit",
"prep": "node ../../../scripts/prepare.js"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/toolbars/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"*.d.ts"
],
"scripts": {
"check": "tsc --noEmit",
"check": "../../../scripts/node_modules/.bin/tsc --noEmit",
"prep": "../../../scripts/prepare/bundle.ts"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion code/addons/viewport/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"*.d.ts"
],
"scripts": {
"check": "tsc --noEmit",
"check": "../../../scripts/node_modules/.bin/tsc --noEmit",
"prep": "../../../scripts/prepare/bundle.ts"
},
"dependencies": {
Expand Down
55 changes: 22 additions & 33 deletions code/examples/angular-cli/src/app/app.component.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,40 +4,29 @@ import { BrowserTestingModule } from '@angular/platform-browser/testing';
import { AppComponent } from './app.component';

describe('AppComponent', () => {
beforeEach(
waitForAsync(() => {
TestBed.configureTestingModule({
imports: [BrowserTestingModule],
declarations: [AppComponent],
}).compileComponents();
})
);
beforeEach(waitForAsync(() => {
TestBed.configureTestingModule({
imports: [BrowserTestingModule],
declarations: [AppComponent],
}).compileComponents();
}));

it(
'should create the app',
waitForAsync(() => {
const fixture = TestBed.createComponent(AppComponent);
const app = fixture.debugElement.componentInstance;
expect(app).toBeTruthy();
})
);
it('should create the app', waitForAsync(() => {
const fixture = TestBed.createComponent(AppComponent);
const app = fixture.debugElement.componentInstance;
expect(app).toBeTruthy();
}));

it(
`should have as title 'app'`,
waitForAsync(() => {
const fixture = TestBed.createComponent(AppComponent);
const app = fixture.debugElement.componentInstance;
expect(app.title).toEqual('app');
})
);
it(`should have as title 'app'`, waitForAsync(() => {
const fixture = TestBed.createComponent(AppComponent);
const app = fixture.debugElement.componentInstance;
expect(app.title).toEqual('app');
}));

it(
'should render title in a h1 tag',
waitForAsync(() => {
const fixture = TestBed.createComponent(AppComponent);
fixture.detectChanges();
const compiled = fixture.debugElement.nativeElement;
expect(compiled.querySelector('h1').textContent).toContain('Welcome to app!');
})
);
it('should render title in a h1 tag', waitForAsync(() => {
const fixture = TestBed.createComponent(AppComponent);
fixture.detectChanges();
const compiled = fixture.debugElement.nativeElement;
expect(compiled.querySelector('h1').textContent).toContain('Welcome to app!');
}));
});
3 changes: 0 additions & 3 deletions code/examples/cra-kitchen-sink/.env

This file was deleted.

52 changes: 0 additions & 52 deletions code/examples/cra-kitchen-sink/.storybook/main.ts

This file was deleted.

14 changes: 0 additions & 14 deletions code/examples/cra-kitchen-sink/.storybook/manager.js

This file was deleted.

11 changes: 0 additions & 11 deletions code/examples/cra-kitchen-sink/.storybook/preview.js

This file was deleted.

46 changes: 0 additions & 46 deletions code/examples/cra-kitchen-sink/package.json

This file was deleted.

Binary file removed code/examples/cra-kitchen-sink/public/favicon.ico
Binary file not shown.
28 changes: 0 additions & 28 deletions code/examples/cra-kitchen-sink/public/index.html

This file was deleted.

Loading

0 comments on commit e957951

Please sign in to comment.