Remove the test-cra example app.

No longer needed, we can now test `cra-kitchen-sink`
storybookjs · Aug 22, 2017 · e27a9c0 · e27a9c0
1 parent 8f4d05a
commit e27a9c0
Show file tree

Hide file tree

Showing 21 changed files with 3 additions and 232 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -72,28 +72,6 @@ jobs:
           name: "Build vue kitchen-sink"
           command: |
             cd examples/vue-kitchen-sink && npm run build-storybook
-  example-test-cra:
-    <<: *defaults
-    steps:
-      - checkout
-      - restore_cache:
-          keys:
-            - root-dependencies-{{ checksum "package.json" }}
-            - root-dependencies-
-      - run:
-          name: "Install root dependencies"
-          command: |
-            yarn install
-      - run:
-          name: "Bootstrapping"
-          command: |
-            npm run bootstrap
-            npm run build-packs
-            npm run bootstrap:test-cra
-      - run:
-          name: "Build test-cra"
-          command: |
-            cd examples/test-cra && npm run build-storybook
   example-react-native:
     <<: *defaults
     steps:
@@ -189,7 +167,6 @@ workflows:
       - validate
       - build
       - example-kitchen-sinks
-      - example-test-cra
       - example-react-native
       - docs
       - lint

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -41,7 +41,7 @@ To test your project against the current latest version of storybook, you can cl
 
 The best way to help figure out an issue you are having is to produce a minimal reproduction against the `master` branch.
 
-A good way to do that is using the example `test-cra` app embedded in this repository:
+A good way to do that is using the example `cra-kitchen-sink` app embedded in this repository:
 
 ```bash
 # Download and build this repository:
@@ -50,7 +50,7 @@ cd storybook
 npm install
 npm run bootstrap
 
-cd examples/test-cra
+cd examples/cra-kitchen-sink
 
 # make changes to try and reproduce the problem, such as adding components + stories
 npm start storybook

diff --git a/examples/test-cra/.gitignore b/examples/test-cra/.gitignore
diff --git a/examples/test-cra/.storybook/addons.js b/examples/test-cra/.storybook/addons.js
diff --git a/examples/test-cra/.storybook/config.js b/examples/test-cra/.storybook/config.js
diff --git a/examples/test-cra/README.md b/examples/test-cra/README.md
diff --git a/examples/test-cra/package.json b/examples/test-cra/package.json
diff --git a/examples/test-cra/public/favicon.ico b/examples/test-cra/public/favicon.ico
diff --git a/examples/test-cra/public/index.html b/examples/test-cra/public/index.html
diff --git a/examples/test-cra/src/App.css b/examples/test-cra/src/App.css
diff --git a/examples/test-cra/src/App.js b/examples/test-cra/src/App.js
diff --git a/examples/test-cra/src/App.test.js b/examples/test-cra/src/App.test.js
diff --git a/examples/test-cra/src/index.css b/examples/test-cra/src/index.css
diff --git a/examples/test-cra/src/index.js b/examples/test-cra/src/index.js
diff --git a/examples/test-cra/src/logo.svg b/examples/test-cra/src/logo.svg
diff --git a/examples/test-cra/src/stories/ComponentWithRef.js b/examples/test-cra/src/stories/ComponentWithRef.js
diff --git a/examples/test-cra/src/stories/index.js b/examples/test-cra/src/stories/index.js
diff --git a/jest.config.js b/jest.config.js
@@ -11,7 +11,6 @@ module.exports = {
     '<rootDir>/app',
     '<rootDir>/lib',
     '<rootDir>/examples/cra-kitchen-sink',
-    '<rootDir>/examples/test-cra',
   ],
   testPathIgnorePatterns: ['/node_modules/'],
   collectCoverage: false,

diff --git a/lerna.json b/lerna.json
@@ -4,15 +4,13 @@
     "bootstrap": {
       "ignore": [
         "crna-kitchen-sink",
-        "test-cra",
         "react-native-vanilla"
       ]
     },
     "publish": {
       "ignore": [
         "cra-kitchen-sink",
         "crna-kitchen-sink",
-        "test-cra",
         "react-native-vanilla",
         "vue-example"
       ]

diff --git a/package.json b/package.json
@@ -10,7 +10,6 @@
     "bootstrap:docs": "cd docs && yarn install",
     "bootstrap:react-native-vanilla": "lerna exec --scope react-native-vanilla -- npm install",
     "bootstrap:crna-kitchen-sink": "lerna exec --scope crna-kitchen-sink -- npm install",
-    "bootstrap:test-cra": "lerna exec --scope test-cra -- npm install",
     "build-packs": "lerna exec --scope '@storybook/*' --parallel -- ../../scripts/build-pack.sh ../../packs",
     "start": "lerna run --stream --scope cra-kitchen-sink storybook",
     "changelog": "pr-log --sloppy",

diff --git a/packs/README.md b/packs/README.md
@@ -2,4 +2,4 @@
 
 This directory is filled with git packs of our packages when you run the `build-packs` command.
 
-The purpose of this is to enable the `test-cra` app to use the packs as "local" installs without linking, and thus behave like a normal app would, yet still use our latest code. It's awkward for development but good to double check things, especially in CI.
+The purpose of this is to enable the example apps to use the packs as "local" installs without linking, and thus behave like a normal app would, yet still use our latest code. It's awkward for development but good to double check things, especially in CI.
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2,4 +2,4 @@

		This directory is filled with git packs of our packages when you run the `build-packs` command.

		The purpose of this is to enable the `test-cra` app to use the packs as "local" installs without linking, and thus behave like a normal app would, yet still use our latest code. It's awkward for development but good to double check things, especially in CI.
		The purpose of this is to enable the example apps to use the packs as "local" installs without linking, and thus behave like a normal app would, yet still use our latest code. It's awkward for development but good to double check things, especially in CI.