Merge pull request #74 from wcastand/master

save height of down panel in local storage #62
storybookjs · Apr 5, 2017 · e01f169 · e01f169
2 parents ff5d73d + 03c28f7
commit e01f169
Show file tree

Hide file tree

Showing 6 changed files with 938 additions and 914 deletions.
diff --git a/dist/modules/api/index.js b/dist/modules/api/index.js
@@ -19,8 +19,8 @@ exports.default = {
   defaultState: {
     uiOptions: {
       name: 'REACT STORYBOOK',
-      sortStoriesByKind: false,
-      url: 'https://github.com/storybooks/react-storybook'
+      url: 'https://github.com/storybooks/react-storybook',
+      sortStoriesByKind: false
     }
   },
   load: function load(_ref, _actions) {
@@ -29,4 +29,4 @@ exports.default = {
 
     (0, _init_api2.default)(provider, clientStore, _actions);
   }
-};
+};
diff --git a/dist/modules/ui/components/layout/index.js b/dist/modules/ui/components/layout/index.js
@@ -137,6 +137,13 @@ var Layout = function (_React$Component) {
         downPanelDefaultSize = downPanelInRight ? 400 : 200;
       }
 
+      if (typeof localStorage !== 'undefined') {
+        var savedSize = localStorage.getItem('splitPos');
+        if (typeof savedSize !== 'undefined') {
+          downPanelDefaultSize = savedSize;
+        }
+      }
+
       return _react2.default.createElement(
         'div',
         { style: rootStyle },
@@ -164,7 +171,12 @@ var Layout = function (_React$Component) {
               defaultSize: downPanelDefaultSize,
               resizerChildren: downPanelInRight ? vsplit : hsplit,
               onDragStarted: onDragStart,
-              onDragFinished: onDragEnd
+              onDragFinished: onDragEnd,
+              onChange: function onChange(size) {
+                if (typeof localStorage !== 'undefined') {
+                  localStorage.setItem('splitPos', size);
+                }
+              }
             },
             _react2.default.createElement(
               'div',

diff --git a/dist/modules/ui/components/left_panel/header.js b/dist/modules/ui/components/left_panel/header.js
@@ -75,7 +75,7 @@ var Header = function Header(_ref) {
     ),
     _react2.default.createElement(
       'a',
-      { style: linkStyle, href: url, target: '_blank' },
+      { style: linkStyle, href: url, target: '_blank', rel: 'noopener noreferrer' },
       _react2.default.createElement(
         'h3',
         { style: headingStyle },

diff --git a/src/modules/ui/components/layout/index.js b/src/modules/ui/components/layout/index.js
@@ -67,6 +67,23 @@ const onDragEnd = function () {
   document.body.classList.remove('dragging');
 };
 
+const saveHeightPanel = h => {
+  try {
+    localStorage.setItem('splitPos', h);
+    return true;
+  } catch (e) {
+    return false;
+  }
+};
+
+const getSavedHeight = h => {
+  try {
+    return localStorage.getItem('splitPos');
+  } catch (e) {
+    return h;
+  }
+};
+
 class Layout extends React.Component {
   constructor(props) {
     super(props);
@@ -124,6 +141,9 @@ class Layout extends React.Component {
       downPanelDefaultSize = downPanelInRight ? 400 : 200;
     }
 
+    // Get the value from localStorage or user downPanelDefaultSize
+    downPanelDefaultSize = getSavedHeight(downPanelDefaultSize);
+
     return (
       <div style={rootStyle}>
         <SplitPane
@@ -147,7 +167,12 @@ class Layout extends React.Component {
             resizerChildren={downPanelInRight ? vsplit : hsplit}
             onDragStarted={onDragStart}
             onDragFinished={onDragEnd}
-            onChange={this.onResize}
+            onChange={
+              size => {
+                saveHeightPanel(size);
+                this.onResize();
+              }
+            }
           >
             <div style={contentPanelStyle}>
               <div

diff --git a/src/modules/ui/components/shortcuts_help.js b/src/modules/ui/components/shortcuts_help.js
@@ -113,7 +113,7 @@ export const ShortcutsHelp = ({ isOpen, onClose, platform }) => (
     isOpen = {isOpen}
     onRequestClose = {onClose}
     style = {modalStyles}
-    contentLabel = 'Shortcuts'
+    contentLabel = "Shortcuts"
   >
     <Shortcuts appShortcuts = {getShortcuts(platform)} />
   </ReactModal>