Skip to content

Commit

Permalink
Merge pull request #24939 from storybookjs/docs_minor_clarifications
Browse files Browse the repository at this point in the history
Docs: Minor clarifications
  • Loading branch information
ndelangen authored Nov 22, 2023
2 parents e97331c + 1a5bcd7 commit d680a4b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion code/presets/create-react-app/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This preset is designed to use alongside [`@storybook/react`](https://github.com

## Compatibility

This version (4.x) of `@storybook/preset-create-react-app` is compatibly with Create React App version 5 and above. Earlier versions are compatible with earlier version of the preset.
From version 4.0.0 onwards, the `@storybook/preset-create-react-app` is compatible with Create React App version 5 and later. If you're using an earlier version of Create React App, you can still utilize the preset's previous versions.

## Basic usage

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { Preview } from '@storybook/your-framework';
const preview: Preview = {
parameters: {
options: {
// The `a` and `b` arguments in this function have a type of `import('@storybook/types').IndexEntry`. Remember that the function is executed in a JavaScript environment, so use JSDoc for IntelliSense to introspect it.
storySort: (a, b) =>
a.id === b.id ? 0 : a.id.localeCompare(b.id, undefined, { numeric: true }),
},
Expand Down
2 changes: 1 addition & 1 deletion docs/writing-tests/test-runner.md
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ You can also configure the test-runner to run tests on a CI environment. Documen

### Run against deployed Storybooks via Github Actions deployment

If you're publishing your Storybook with services such as [Vercel](https://vercel.com/) or [Netlify](https://www.netlify.com/), they emit a `deployment_status` event in GitHub Actions. You can use it and set the `deployment_status.target_url` as the `TARGET_URL` environment variable. Here's how:
If you're publishing your Storybook with services such as [Vercel](https://vercel.com/) or [Netlify](https://docs.netlify.com/site-deploys/notifications/#github-commit-statuses), they emit a `deployment_status` event in GitHub Actions. You can use it and set the `deployment_status.target_url` as the `TARGET_URL` environment variable. Here's how:

<!-- prettier-ignore-start -->

Expand Down

0 comments on commit d680a4b

Please sign in to comment.