Skip to content

Commit

Permalink
Merge pull request #22998 from storybookjs/norbert/playwright-fix
Browse files Browse the repository at this point in the history
Build: Remove `playwright` and `playwright-core`, but keep the resolutions
  • Loading branch information
ndelangen authored and kasperpeulen committed Jun 9, 2023
1 parent 40e1e88 commit d09dda9
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
1 change: 0 additions & 1 deletion code/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,6 @@
"lodash": "^4.17.21",
"node-gyp": "^8.4.0",
"nx": "^15.4.5",
"playwright": "1.32.3",
"prettier": "2.8.0",
"process": "^0.11.10",
"raf": "^3.4.1",
Expand Down
1 change: 0 additions & 1 deletion code/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6923,7 +6923,6 @@ __metadata:
lodash: ^4.17.21
node-gyp: ^8.4.0
nx: ^15.4.5
playwright: 1.32.3
prettier: 2.8.0
process: ^0.11.10
raf: ^3.4.1
Expand Down
2 changes: 2 additions & 0 deletions scripts/utils/yarn.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ export const addPackageResolutions = async ({ cwd, dryRun }: YarnOptions) => {
...storybookVersions,
'enhanced-resolve': '~5.10.0', // TODO, remove this
// this is for our CI test, ensure we use the same version as docker image, it should match version specified in `./code/package.json` and `.circleci/config.yml`
playwright: '^1.35.0',
'playwright-core': '^1.35.0',
'@playwright/test': '^1.35.0',
};
await writeJSON(packageJsonPath, packageJson, { spaces: 2 });
Expand Down

0 comments on commit d09dda9

Please sign in to comment.