Skip to content

Commit

Permalink
Upgrade boxen to 5.x
Browse files Browse the repository at this point in the history
The breaking change in this major version is dropping support for
node <10, and storybook already requires node 10+.
This removes one path depending on outdated versions of ansi-regex that
are vulnerable for ReDoS.
  • Loading branch information
stof committed Sep 29, 2021
1 parent d11b386 commit b015579
Show file tree
Hide file tree
Showing 3 changed files with 55 additions and 5 deletions.
2 changes: 1 addition & 1 deletion lib/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"@storybook/core-common": "6.4.0-beta.1",
"@storybook/node-logger": "6.4.0-beta.1",
"@storybook/semver": "^7.3.2",
"boxen": "^4.2.0",
"boxen": "^5.1.2",
"chalk": "^4.1.0",
"commander": "^6.2.1",
"core-js": "^3.8.2",
Expand Down
2 changes: 1 addition & 1 deletion lib/core-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"@types/pretty-hrtime": "^1.0.0",
"@types/webpack": "^4.41.26",
"better-opn": "^2.1.1",
"boxen": "^4.2.0",
"boxen": "^5.1.2",
"chalk": "^4.1.0",
"cli-table3": "0.6.0",
"commander": "^6.2.1",
Expand Down
56 changes: 53 additions & 3 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -7812,7 +7812,7 @@ __metadata:
"@types/semver": ^7.3.4
"@types/shelljs": ^0.8.7
"@types/update-notifier": ^5.0.0
boxen: ^4.2.0
boxen: ^5.1.2
chalk: ^4.1.0
commander: ^6.2.1
core-js: ^3.8.2
Expand Down Expand Up @@ -8065,7 +8065,7 @@ __metadata:
"@types/serve-favicon": ^2.5.2
"@types/webpack": ^4.41.26
better-opn: ^2.1.1
boxen: ^4.2.0
boxen: ^5.1.2
chalk: ^4.1.0
cli-table3: 0.6.0
commander: ^6.2.1
Expand Down Expand Up @@ -12927,6 +12927,13 @@ __metadata:
languageName: node
linkType: hard

"ansi-regex@npm:^5.0.1":
version: 5.0.1
resolution: "ansi-regex@npm:5.0.1"
checksum: 9a64bb8627b434ba9327b60c027742e5d17ac69277960d041898596271d992d4d52ba7267a63ca10232e29f6107fc8a835f6ce8d719b88c5f8493f8254813737
languageName: node
linkType: hard

"ansi-styles@npm:^2.2.1":
version: 2.2.1
resolution: "ansi-styles@npm:2.2.1"
Expand Down Expand Up @@ -14825,6 +14832,22 @@ __metadata:
languageName: node
linkType: hard

"boxen@npm:^5.1.2":
version: 5.1.2
resolution: "boxen@npm:5.1.2"
dependencies:
ansi-align: ^3.0.0
camelcase: ^6.2.0
chalk: ^4.1.0
cli-boxes: ^2.2.1
string-width: ^4.2.2
type-fest: ^0.20.2
widest-line: ^3.1.0
wrap-ansi: ^7.0.0
checksum: 71f31c2eb3dcacd5fce524ae509e0cc90421752e0bfbd0281fd3352871d106c462a0f810c85f2fdb02f3a9fab2d7a84e9718b4999384d651b76104ebe5d2c024
languageName: node
linkType: hard

"brace-expansion@npm:^1.1.7":
version: 1.1.11
resolution: "brace-expansion@npm:1.1.11"
Expand Down Expand Up @@ -16653,7 +16676,7 @@ __metadata:
languageName: node
linkType: hard

"cli-boxes@npm:^2.2.0":
"cli-boxes@npm:^2.2.0, cli-boxes@npm:^2.2.1":
version: 2.2.1
resolution: "cli-boxes@npm:2.2.1"
checksum: 6111352edbb2f62dbc7bfd58f2d534de507afed7f189f13fa894ce5a48badd94b2aa502fda28f1d7dd5f1eb456e7d4033d09a76660013ef50c7f66e7a034f050
Expand Down Expand Up @@ -41480,6 +41503,17 @@ [email protected]:
languageName: node
linkType: hard

"string-width@npm:^4.2.2":
version: 4.2.3
resolution: "string-width@npm:4.2.3"
dependencies:
emoji-regex: ^8.0.0
is-fullwidth-code-point: ^3.0.0
strip-ansi: ^6.0.1
checksum: 1e525e92e5eae0afd7454086eed9c818ee84374bb80328fc41217ae72ff5f065ef1c9d7f72da41de40c75fa8bb3dee63d92373fd492c84260a552c636392a47b
languageName: node
linkType: hard

"string.prototype.matchall@npm:^4.0.0 || ^3.0.1, string.prototype.matchall@npm:^4.0.2":
version: 4.0.4
resolution: "string.prototype.matchall@npm:4.0.4"
Expand Down Expand Up @@ -41638,6 +41672,15 @@ [email protected]:
languageName: node
linkType: hard

"strip-ansi@npm:^6.0.1":
version: 6.0.1
resolution: "strip-ansi@npm:6.0.1"
dependencies:
ansi-regex: ^5.0.1
checksum: 1ae5f212a126fe5b167707f716942490e3933085a5ff6c008ab97ab2f272c8025d3aa218b7bd6ab25729ca20cc81cddb252102f8751e13482a5199e873680952
languageName: node
linkType: hard

"strip-bom@npm:^2.0.0":
version: 2.0.0
resolution: "strip-bom@npm:2.0.0"
Expand Down Expand Up @@ -43576,6 +43619,13 @@ [email protected]:
languageName: node
linkType: hard

"type-fest@npm:^0.20.2":
version: 0.20.2
resolution: "type-fest@npm:0.20.2"
checksum: dea9df45ea1f0aaa4e2d3bed3f9a0bfe9e5b2592bddb92eb1bf06e50bcf98dbb78189668cd8bc31a0511d3fc25539b4cd5c704497e53e93e2d40ca764b10bfc3
languageName: node
linkType: hard

"type-fest@npm:^0.3.0, type-fest@npm:^0.3.1":
version: 0.3.1
resolution: "type-fest@npm:0.3.1"
Expand Down

0 comments on commit b015579

Please sign in to comment.