Skip to content

Commit

Permalink
ADD a step in circleci to upload storybook for angular (#8477)
Browse files Browse the repository at this point in the history
ADD a step in circleci to upload storybook for angular
  • Loading branch information
ndelangen authored Oct 18, 2019
2 parents ddd159d + d2ac2ec commit a64df49
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
8 changes: 6 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,12 @@ jobs:
- attach_workspace:
at: .
- run:
name: Run chromatic on the pre-built storybook
command: yarn chromatic
name: Run chromatic on the pre-built official example
command: yarn chromatic --storybook-build-dir="built-storybooks/official-storybook" --exit-zero-on-changes --app-code="ab7m45tp9p"
- run:
name: Run chromatic on the pre-built angular example
command: yarn chromatic --storybook-build-dir="built-storybooks/angular-cli" --exit-zero-on-changes --app-code="tl92yzsj6w"

packtracker:
<<: *defaults
steps:
Expand Down
2 changes: 1 addition & 1 deletion examples/angular-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "MIT",
"scripts": {
"build": "ng build",
"prebuild-storybook": "npm run storybook:prebuild && cd ../.. && yarn add node-sass -W -s && cd examples/angular-cli",
"prebuild-storybook": "npm run storybook:prebuild",
"build-storybook": "build-storybook -s src/assets",
"e2e": "ng e2e",
"ng": "ng",
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
"build-storybooks": "cross-env STORYBOOK_DISPLAY_WARNING=true DISPLAY_WARNING=true ./scripts/build-storybooks.js",
"changelog": "pr-log --sloppy --cherry-pick",
"changelog:next": "pr-log --sloppy --since-prerelease",
"chromatic": "chromatic --storybook-build-dir=\"built-storybooks/official-storybook\" --exit-zero-on-changes --app-code=\"ab7m45tp9p\"",
"coverage": "codecov",
"danger": "danger",
"dev": "concurrently --kill-others \"yarn dev:tsc\" \"yarn dev:babel\"",
Expand Down

1 comment on commit a64df49

@vercel
Copy link

@vercel vercel bot commented on a64df49 Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.