throw an error with unexpected node value

storybookjs · Jan 19, 2023 · 9c541c8 · 9c541c8
1 parent b59bee6
commit 9c541c8
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/code/lib/csf-tools/src/ConfigFile.test.ts b/code/lib/csf-tools/src/ConfigFile.test.ts
@@ -768,15 +768,15 @@ describe('ConfigFile', () => {
           import type { StorybookConfig } from '@storybook/react-webpack5';
 
           const config: StorybookConfig = {
-            framework: { name: 'foo', options: {} },
+            framework: { name: 'foo', options: { bar: require('baz') } },
           }
           export default config;
         `;
         const config = loadConfig(source).parse();
         expect(config.getNameFromPath(['framework'])).toEqual('foo');
       });
 
-      it(`returns undefined with unexpected node value`, () => {
+      it(`throws an error with unexpected node value`, () => {
         const source = dedent`
           import type { StorybookConfig } from '@storybook/react-webpack5';
 
@@ -786,7 +786,9 @@ describe('ConfigFile', () => {
           export default config;
         `;
         const config = loadConfig(source).parse();
-        expect(config.getNameFromPath(['framework'])).toBeUndefined();
+        expect(() => config.getNameFromPath(['framework'])).toThrowError(
+          `The given node must be a string literal or an object expression with a "name" property that is a string literal.`
+        );
       });
     });
 

diff --git a/code/lib/csf-tools/src/ConfigFile.ts b/code/lib/csf-tools/src/ConfigFile.ts
@@ -318,6 +318,12 @@ export class ConfigFile {
       });
     }
 
+    if (!value) {
+      throw new Error(
+        `The given node must be a string literal or an object expression with a "${fallbackProperty}" property that is a string literal.`
+      );
+    }
+
     return value;
   }