Skip to content

Commit

Permalink
Merge pull request #19179 from storybookjs/tom/sb-701-migrate-stories…
Browse files Browse the repository at this point in the history
…-and-delete-cra-ts

Remove `cra-kitchen-sink` example
  • Loading branch information
ndelangen authored Sep 14, 2022
2 parents 8b5d3b0 + 3b23669 commit 8def4a4
Show file tree
Hide file tree
Showing 31 changed files with 4 additions and 519 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ jobs:
executor:
class: medium+
name: sb_node_14_browsers
parallelism: 15
parallelism: 14
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.old.md
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ Then run `yarn cypress open` if you want to see the tests run in the UI, or `yar

The best way to help figure out an issue you are having is to produce a minimal reproduction against the `main` branch.

A good way to do that is using the example `cra-kitchen-sink` app embedded in this repository:
A good way to do that is using the example `official-storybook` app embedded in this repository:

```sh
# Download and build this repository:
Expand All @@ -157,7 +157,7 @@ yarn
yarn bootstrap --core

# make changes to try and reproduce the problem, such as adding components + stories
cd examples/cra-kitchen-sink
cd examples/official-storybook
yarn storybook

# see if you can see the problem, if so, commit it:
Expand Down
1 change: 0 additions & 1 deletion code/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ package-lock.json
storybook-static
integration/__image_snapshots__/__diff_output__
.jest-test-results.json
/examples/cra-kitchen-sink/src/__image_snapshots__/__diff_output__/
lib/*.jar
lib/**/dll
/false
Expand Down
3 changes: 0 additions & 3 deletions code/examples/cra-kitchen-sink/.env

This file was deleted.

52 changes: 0 additions & 52 deletions code/examples/cra-kitchen-sink/.storybook/main.ts

This file was deleted.

14 changes: 0 additions & 14 deletions code/examples/cra-kitchen-sink/.storybook/manager.js

This file was deleted.

11 changes: 0 additions & 11 deletions code/examples/cra-kitchen-sink/.storybook/preview.js

This file was deleted.

46 changes: 0 additions & 46 deletions code/examples/cra-kitchen-sink/package.json

This file was deleted.

Binary file removed code/examples/cra-kitchen-sink/public/favicon.ico
Binary file not shown.
28 changes: 0 additions & 28 deletions code/examples/cra-kitchen-sink/public/index.html

This file was deleted.

30 changes: 0 additions & 30 deletions code/examples/cra-kitchen-sink/src/App.css

This file was deleted.

17 changes: 0 additions & 17 deletions code/examples/cra-kitchen-sink/src/App.js

This file was deleted.

9 changes: 0 additions & 9 deletions code/examples/cra-kitchen-sink/src/base.css

This file was deleted.

40 changes: 0 additions & 40 deletions code/examples/cra-kitchen-sink/src/components/Container.js

This file was deleted.

This file was deleted.

53 changes: 0 additions & 53 deletions code/examples/cra-kitchen-sink/src/components/LifecycleLogger.js

This file was deleted.

34 changes: 0 additions & 34 deletions code/examples/cra-kitchen-sink/src/components/react-demo.js

This file was deleted.

Loading

0 comments on commit 8def4a4

Please sign in to comment.