Merge pull request #22998 from storybookjs/norbert/playwright-fix

Build: Remove `playwright` and `playwright-core`, but keep the resolutions
storybookjs · Jun 9, 2023 · 7ec2942 · 7ec2942
2 parents 483bd65 + ab6caf5
commit 7ec2942
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/code/package.json b/code/package.json
@@ -246,8 +246,6 @@
     "node-gyp": "^9.3.1",
     "nx": "16.2.1",
     "nx-cloud": "16.0.5",
-    "playwright": "^1.35.0",
-    "playwright-core": "^1.35.0",
     "prettier": "2.8.0",
     "process": "^0.11.10",
     "raf": "^3.4.1",

diff --git a/code/yarn.lock b/code/yarn.lock
@@ -7210,8 +7210,6 @@ __metadata:
     node-gyp: ^9.3.1
     nx: 16.2.1
     nx-cloud: 16.0.5
-    playwright: ^1.35.0
-    playwright-core: ^1.35.0
     prettier: 2.8.0
     process: ^0.11.10
     raf: ^3.4.1

diff --git a/scripts/utils/yarn.ts b/scripts/utils/yarn.ts
@@ -24,6 +24,8 @@ export const addPackageResolutions = async ({ cwd, dryRun }: YarnOptions) => {
     ...storybookVersions,
     'enhanced-resolve': '~5.10.0', // TODO, remove this
     // this is for our CI test, ensure we use the same version as docker image, it should match version specified in `./code/package.json` and `.circleci/config.yml`
+    playwright: '^1.35.0',
+    'playwright-core': '^1.35.0',
     '@playwright/test': '^1.35.0',
   };
   await writeJSON(packageJsonPath, packageJson, { spaces: 2 });