Reused Storybook's Options core type and applied fix to vue3 framework

storybookjs · Mar 16, 2021 · 797c605 · 797c605
1 parent 193cf98
commit 797c605
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 15 deletions.
diff --git a/addons/docs/src/frameworks/vue/preset.ts b/addons/docs/src/frameworks/vue/preset.ts
@@ -1,19 +1,9 @@
-interface Preset {
-  readonly name: string;
-  readonly options: any;
-}
-
-interface PresetOptions {
-  readonly presetsList: Preset[];
-}
+import type { Options } from '@storybook/core-common';
 
-export function webpackFinal(
-  webpackConfig: any = {},
-  options: PresetOptions = { presetsList: [] }
-) {
+export function webpackFinal(webpackConfig: any = {}, options: Options) {
   let vueDocgenOptions = {};
 
-  options.presetsList.forEach((preset) => {
+  options.presetsList?.forEach((preset) => {
     if (preset.name.includes('addon-docs') && preset.options.vueDocgenOptions) {
       const appendableOptions = preset.options.vueDocgenOptions;
       vueDocgenOptions = {

diff --git a/addons/docs/src/frameworks/vue3/preset.ts b/addons/docs/src/frameworks/vue3/preset.ts
@@ -1,12 +1,26 @@
-export function webpackFinal(webpackConfig: any = {}, options: any = {}) {
+import type { Options } from '@storybook/core-common';
+
+export function webpackFinal(webpackConfig: any = {}, options: Options) {
+  let vueDocgenOptions = {};
+
+  options.presetsList?.forEach((preset) => {
+    if (preset.name.includes('addon-docs') && preset.options.vueDocgenOptions) {
+      const appendableOptions = preset.options.vueDocgenOptions;
+      vueDocgenOptions = {
+        ...vueDocgenOptions,
+        ...appendableOptions,
+      };
+    }
+  });
+
   webpackConfig.module.rules.push({
     test: /\.vue$/,
     loader: require.resolve('vue-docgen-loader', { paths: [require.resolve('@storybook/vue3')] }),
     enforce: 'post',
     options: {
       docgenOptions: {
         alias: webpackConfig.resolve.alias,
-        ...options.vueDocgenOptions,
+        ...vueDocgenOptions,
       },
     },
   });