fix: don't remove redundant filename part if there won't be anything …

…left
storybookjs · Sep 20, 2023 · 59fc329 · 59fc329
1 parent 8ce45d5
commit 59fc329
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/code/lib/preview-api/src/modules/store/autoTitle.test.ts b/code/lib/preview-api/src/modules/store/autoTitle.test.ts
@@ -240,6 +240,18 @@ describe('userOrAutoTitleFromSpecifier', () => {
         ).toMatchInlineSnapshot(`to_my/file`);
       });
 
+      it('match with short path', () => {
+        // Make sure "stories" isn't trimmed as redundant when there won't be
+        // anything left.
+        expect(
+          userOrAuto(
+            './path/stories.js',
+            normalizeStoriesEntry({ directory: './path', files: '**/?(*.)stories.*' }, options),
+            undefined
+          )
+        ).toMatchInlineSnapshot(`stories`);
+      });
+
       it('match with windows path', () => {
         expect(
           userOrAuto(

diff --git a/code/lib/preview-api/src/modules/store/autoTitle.ts b/code/lib/preview-api/src/modules/store/autoTitle.ts
@@ -15,7 +15,7 @@ const stripExtension = (parts: string[]) => {
 const removeRedundantFilename = (parts: string[]) => {
   const last = parts[parts.length - 1];
   const nextToLast = parts[parts.length - 2];
-  return last && (last === nextToLast || /^(?:index|story|stories)$/i.test(last))
+  return last && nextToLast && (last === nextToLast || /^(?:index|story|stories)$/i.test(last))
     ? parts.slice(0, -1)
     : parts;
 };