Skip to content

Commit

Permalink
Merge pull request #22992 from storybookjs/shilman/upgrade-playwright
Browse files Browse the repository at this point in the history
Build: Upgrade playwright to 1.35.0
(cherry picked from commit 10e6a67)
  • Loading branch information
ndelangen authored and shilman committed Jun 13, 2023
1 parent 8b19135 commit 3da9762
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ executors:
default: 'small'
working_directory: /tmp/storybook
docker:
- image: mcr.microsoft.com/playwright:v1.32.3-focal
- image: mcr.microsoft.com/playwright:v1.35.0-focal
environment:
NODE_OPTIONS: --max_old_space_size=6144
resource_class: <<parameters.class>>
Expand Down
4 changes: 2 additions & 2 deletions code/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"defaults"
],
"resolutions": {
"@playwright/test": "1.32.3",
"@playwright/test": "1.35.0",
"@typescript-eslint/eslint-plugin": "^5.45.0",
"@typescript-eslint/experimental-utils": "^5.45.0",
"@typescript-eslint/parser": "^5.45.0",
Expand All @@ -99,7 +99,7 @@
"@nrwl/cli": "^15.4.5",
"@nrwl/nx-cloud": "^15.0.2",
"@nrwl/workspace": "^15.4.5",
"@playwright/test": "1.32.3",
"@playwright/test": "^1.35.0",
"@storybook/addon-a11y": "workspace:*",
"@storybook/addon-actions": "workspace:*",
"@storybook/addon-backgrounds": "workspace:*",
Expand Down
21 changes: 15 additions & 6 deletions code/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4593,19 +4593,19 @@ __metadata:
languageName: node
linkType: hard

"@playwright/test@npm:1.32.3":
version: 1.32.3
resolution: "@playwright/test@npm:1.32.3"
"@playwright/test@npm:1.35.0":
version: 1.35.0
resolution: "@playwright/test@npm:1.35.0"
dependencies:
"@types/node": "*"
fsevents: 2.3.2
playwright-core: 1.32.3
playwright-core: 1.35.0
dependenciesMeta:
fsevents:
optional: true
bin:
playwright: cli.js
checksum: d09e4135c868b4067f45b8c297d02b0d8ddb8298657c942a06c72f3d9a3236af94586718dc7590693dbb31ea4b8fcceeb8a1e8811072f2add7d952c5c9129df3
checksum: 77594d876632e9ce8a33851fed0a9ffe1034ca216811a3b5c3925c371eddb20ceb6848f3e9b10234a025dcf7be979cddcd0285ad627ad30afbc0cf246ab74c4d
languageName: node
linkType: hard

Expand Down Expand Up @@ -6777,7 +6777,7 @@ __metadata:
"@nrwl/cli": ^15.4.5
"@nrwl/nx-cloud": ^15.0.2
"@nrwl/workspace": ^15.4.5
"@playwright/test": 1.32.3
"@playwright/test": ^1.35.0
"@storybook/addon-a11y": "workspace:*"
"@storybook/addon-actions": "workspace:*"
"@storybook/addon-backgrounds": "workspace:*"
Expand Down Expand Up @@ -24536,6 +24536,15 @@ __metadata:
languageName: node
linkType: hard

"playwright-core@npm:1.35.0":
version: 1.35.0
resolution: "playwright-core@npm:1.35.0"
bin:
playwright-core: cli.js
checksum: 157257f0950190903d75ff6af70258fe1b1c6bf44f144a063428a594c09b4631d4c151ff65e28e1d9fc13edd8bd51c4720a7d87fc755c2afba47f41919bf5875
languageName: node
linkType: hard

"playwright@npm:1.32.3":
version: 1.32.3
resolution: "playwright@npm:1.32.3"
Expand Down
3 changes: 1 addition & 2 deletions scripts/utils/yarn.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ export const addPackageResolutions = async ({ cwd, dryRun }: YarnOptions) => {
...storybookVersions,
'enhanced-resolve': '~5.10.0', // TODO, remove this
// this is for our CI test, ensure we use the same version as docker image, it should match version specified in `./code/package.json` and `.circleci/config.yml`
'@playwright/test': '1.32.3',
playwright: '1.32.3',
'@playwright/test': '^1.35.0',
};
await writeJSON(packageJsonPath, packageJson, { spaces: 2 });
};
Expand Down

0 comments on commit 3da9762

Please sign in to comment.