Skip to content

Commit

Permalink
remove message, after talking it over, it's too noisy
Browse files Browse the repository at this point in the history
  • Loading branch information
ndelangen committed Nov 28, 2022
1 parent d6bb929 commit 3442b18
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 15 deletions.
1 change: 0 additions & 1 deletion code/lib/builder-vite/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@
"devDependencies": {
"@types/express": "^4.17.13",
"@types/node": "^16.0.0",
"ts-dedent": "^2.0.0",
"typescript": "^4.9.3",
"vite": "^3.1.3"
},
Expand Down
13 changes: 0 additions & 13 deletions code/lib/builder-vite/src/vite-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@ import viteReact from '@vitejs/plugin-react';
import externalGlobals from 'rollup-plugin-external-globals';
import { isPreservingSymlinks, getFrameworkName } from '@storybook/core-common';
import { globals } from '@storybook/preview/globals';
// eslint-disable-next-line import/no-extraneous-dependencies
import dedent from 'ts-dedent';
import {
codeGeneratorPlugin,
injectExportOrderPlugin,
Expand Down Expand Up @@ -48,17 +46,6 @@ export async function commonConfig(
const { config: { build: buildProperty = undefined, ...userConfig } = {} } =
(await loadConfigFromFile(configEnv)) ?? {};

if (buildProperty) {
console.warn(
dedent`
The 'build' property in your vite config is not supported by storybook. Please use the viteFinal function in main.js to configure the build.
This is because storybook needs to configure the build for you.
Often the user's (your) app, needs 'build' config that is different from storybook.
`
);
}

const sbConfig: InlineConfig = {
configFile: false,
cacheDir: 'node_modules/.cache/.vite-storybook',
Expand Down
1 change: 0 additions & 1 deletion code/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5894,7 +5894,6 @@ __metadata:
magic-string: ^0.26.1
rollup-plugin-external-globals: ^0.7.1
slash: ^3.0.0
ts-dedent: ^2.0.0
typescript: ^4.9.3
vite: ^3.1.3
peerDependencies:
Expand Down

0 comments on commit 3442b18

Please sign in to comment.