Don't append title prefix to Meta of= docs entries

storybookjs · Jul 6, 2022 · 256c738 · 256c738
1 parent 099c724
commit 256c738
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/lib/core-server/src/utils/StoryIndexGenerator.test.ts b/lib/core-server/src/utils/StoryIndexGenerator.test.ts
@@ -525,6 +525,33 @@ describe('StoryIndexGenerator', () => {
         `);
       });
 
+      it('does not append title prefix if meta references a CSF file', async () => {
+        const generator = new StoryIndexGenerator(
+          [
+            storiesSpecifier,
+            normalizeStoriesEntry(
+              { directory: './src/docs2', files: '**/*.mdx', titlePrefix: 'titlePrefix' },
+              options
+            ),
+          ],
+          options
+        );
+        await generator.initialize();
+
+        // NOTE: `toMatchInlineSnapshot` on objects sorts the keys, but in actuality, they are
+        // not sorted by default.
+        expect(Object.values((await generator.getIndex()).entries).map((e) => e.title))
+          .toMatchInlineSnapshot(`
+          Array [
+            "A",
+            "A",
+            "titlePrefix/NoTitle",
+            "A",
+            "titlePrefix/docs2/Yabbadabbadooo",
+          ]
+        `);
+      });
+
       it('generates no docs entries when docs are disabled', async () => {
         const generator = new StoryIndexGenerator([storiesSpecifier, docsSpecifier], {
           ...options,

diff --git a/lib/core-server/src/utils/StoryIndexGenerator.ts b/lib/core-server/src/utils/StoryIndexGenerator.ts
@@ -307,7 +307,7 @@ export class StoryIndexGenerator {
         dep.dependents.push(absolutePath);
       });
 
-      const title = userOrAutoTitleFromSpecifier(importPath, specifier, result.title || ofTitle);
+      const title = ofTitle || userOrAutoTitleFromSpecifier(importPath, specifier, result.title);
       const name = result.name || this.options.docs.defaultName;
       const id = toId(title, name);