tests: remove stale helper

storybookjs · Nov 1, 2020 · 1026ab9 · 1026ab9
1 parent ba3bf71
commit 1026ab9
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 56 deletions.
diff --git a/lib/cli/test/commands/init.test.js b/lib/cli/test/commands/init.test.js
@@ -2,7 +2,7 @@ const fs = require('fs');
 const fse = require('fs-extra');
 const path = require('path');
 
-const { run } = require('../helpers');
+const run = require('../helpers');
 
 const fixturesDirPath = path.join(__dirname, '..', 'fixtures');
 const runDirPath = path.join(__dirname, '..', 'run');
@@ -26,28 +26,28 @@ afterAll(() => {
 
 describe('sb init', () => {
   it('starts storybook without errors', () => {
-    // const dirs = fs.readdirSync(runDirPath).filter((dir) => !dir.includes('vue'));
-    // dirs.forEach((dir) => {
-    //   run(['init', '--skip-install', 'yes'], { cwd: path.join(runDirPath, dir) });
-    // });
-    //
-    // // Install all the dependencies in a single run
-    // console.log('Running bootstrap');
-    // run(
-    //   ['yarn', 'install', '--non-interactive', '--silent', '--pure-lockfile'],
-    //   { cwd: rootPath },
-    //   false
-    // );
-    //
-    // // Check that storybook starts without errors
-    // dirs.forEach((dir) => {
-    //   console.log(`Running smoke test in ${dir}`);
-    //   const { status } = run(
-    //     ['yarn', 'storybook', '--smoke-test', '--quiet'],
-    //     { cwd: path.join(runDirPath, dir) },
-    //     false
-    //   );
-    //   expect(status).toBe(0);
-    // });
+    const dirs = fs.readdirSync(runDirPath).filter((dir) => !dir.includes('vue'));
+    dirs.forEach((dir) => {
+      run(['init', '--skip-install', 'yes'], { cwd: path.join(runDirPath, dir) });
+    });
+
+    // Install all the dependencies in a single run
+    console.log('Running bootstrap');
+    run(
+      ['yarn', 'install', '--non-interactive', '--silent', '--pure-lockfile'],
+      { cwd: rootPath },
+      false
+    );
+
+    // Check that storybook starts without errors
+    dirs.forEach((dir) => {
+      console.log(`Running smoke test in ${dir}`);
+      const { status } = run(
+        ['yarn', 'storybook', '--smoke-test', '--quiet'],
+        { cwd: path.join(runDirPath, dir) },
+        false
+      );
+      expect(status).toBe(0);
+    });
   });
 });
diff --git a/lib/cli/test/default/cli.test.js b/lib/cli/test/default/cli.test.js
@@ -1,4 +1,4 @@
-const { run } = require('../helpers');
+const run = require('../helpers');
 
 describe('Default behavior', () => {
   it('suggests the closest match to an unknown command', () => {

diff --git a/lib/cli/test/helpers.js b/lib/cli/test/helpers.js
@@ -1,36 +1,9 @@
 const { sync: spawnSync } = require('cross-spawn');
 const fs = require('fs');
-const fse = require('fs-extra');
 const path = require('path');
 
 const CLI_PATH = path.join(__dirname, '..', 'bin');
 
-/**
- * Copy directory content recursively
- * @param {String} source - source directory path
- * @param {String} target - path to the destination directory
- * @returns {Void}
- */
-const copyDirSync = (source, target) => {
-  // check if folder needs to be created or integrated
-  const targetFolder = path.join(target, path.basename(source));
-  if (!fs.existsSync(targetFolder)) {
-    fs.mkdirSync(targetFolder);
-  }
-
-  // copy
-  if (fs.lstatSync(source).isDirectory()) {
-    fs.readdirSync(source).forEach((file) => {
-      const curSource = path.join(source, file);
-      if (fs.lstatSync(curSource).isDirectory()) {
-        copyDirSync(curSource, targetFolder);
-      } else {
-        fse.copySync(curSource, targetFolder);
-      }
-    });
-  }
-};
-
 /**
  * Execute command
  * @param {String[]} args - args to be passed in
@@ -40,7 +13,4 @@ const copyDirSync = (source, target) => {
 const run = (args, options = {}, cli = true) =>
   spawnSync(cli ? 'node' : args[0], cli ? [CLI_PATH].concat(args) : args.slice(1), options);
 
-module.exports = {
-  copyDirSync,
-  run,
-};
+module.exports = run;