Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better web controls #322

Merged
merged 1 commit into from
Feb 8, 2022
Merged

fix: better web controls #322

merged 1 commit into from
Feb 8, 2022

Conversation

dannyhw
Copy link
Member

@dannyhw dannyhw commented Jan 31, 2022

Issue: #280 #281 #283

What I did

  • select now uses default select html when on the web platform
  • date picker now uses local-datetime input on the web
  • color picker now color input type on the web
  • some ui improvements for the color picker on device

How to test

run the example app on web,android and web to check everything is still working

image
image
image

@raychanks
Copy link
Contributor

The color input seems nicer :)

For the datetime picker, it seems to work fine if I change the value by clicking the calendar icon, but not if I try to type in the values directly. For example, if I want to input 22/01/2022, I cannot input 22 in the day field. Should we also cater for the case of direct input?

@dannyhw
Copy link
Member Author

dannyhw commented Feb 8, 2022

@raychanks I agree its not ideal, though I had some issues making the typing version work. I'm thinking to merge this just to make something work and then add a task to improve it. Thats because currently it just doesn't work on web so something is better than nothing.

@dannyhw dannyhw merged commit 8f914c4 into next-6.0 Feb 8, 2022
@dannyhw dannyhw deleted the fix/rnw-controls branch February 2, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants