Remove react-typescript-docgen-loader from preset-typescript
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
changed the title
react-typescript-docgen-loader from preset-typescript (for non-react support)
shilman
changed the title
react-typescript-docgen-loader from preset-typescript (for non-react support)react-typescript-docgen-loader from preset-typescript
patricklafrance
approved these changes
Nov 27, 2019
mrmckeb
approved these changes
Dec 1, 2019
|
Looks great! |
|
@patricklafrance I'll merge & release once storybookjs/storybook#8984 is ready |
|
@shilman 👍 |
|
@shilman @patricklafrance can we get this merged? I'm working on an easier vue+ts setup and this is would help simplify things. |
This was referenced Feb 28, 2020
graup
added a commit
to graup/presets
that referenced
this pull request
Feb 28, 2020
- Remove `react-typescript-docgen-loader` from `preset-typescript` (rollup storybookjs#68) - Don't default to empty include option (rollup storybookjs#106) - Add appendTsSuffixTo to tsLoader options if framework is vue
This was referenced Mar 5, 2020
graup
added a commit
to graup/presets
that referenced
this pull request
Mar 5, 2020
- Remove `react-typescript-docgen-loader` from `preset-typescript` (rollup storybookjs#68) - Don't default to empty include option (rollup storybookjs#106) - Add appendTsSuffixTo to tsLoader options if framework is vue
This was referenced Mar 5, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Removed all instances of
react-typescript-docgen-loaderfrompreset-typescriptper storybookjs/storybook#8337 sincepreset-typescriptshould be for all frameworks, not just react.Incremented major version change
There's an accompanying PR that adds it to
addon-docs: storybookjs/storybook#8984