Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix canvas mdxSource generation and add tests #25

Merged
merged 14 commits into from
Nov 7, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Nov 7, 2022

Issue: storybookjs/storybook#18342

What Changed

Fixed mdxSource generation based on #16 from @zhyd1997. Thank you @zhyd1997 !!! 🙏

Self-merging @tmeasday

How to test

See updated:

  • Unit tests
  • E2E example in storybook

Change Type

  • maintenance
  • documentation
  • patch
  • minor
  • major
📦 Published PR as canary version: 0.0.4-canary.25.2de60c7.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

Version

Published prerelease version: v0.1.0-next.5

Changelog

🚀 Enhancement

🐛 Bug Fix

Authors: 5

@shilman shilman added the patch Increment the patch version when merged label Nov 7, 2022
@shilman shilman added the bug Something isn't working label Nov 7, 2022
@shilman shilman merged commit 7e62a15 into next Nov 7, 2022
@shilman shilman deleted the shilman/18342-fix-canvas-source branch November 7, 2022 04:43
This was referenced Dec 1, 2022
@github-actions github-actions bot mentioned this pull request Dec 30, 2022
5 tasks
@github-actions github-actions bot mentioned this pull request Jan 6, 2023
5 tasks
@github-actions github-actions bot mentioned this pull request Jan 21, 2023
5 tasks
This was referenced Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants