Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Simplify dependencies, support node 14+ #2

Merged
merged 4 commits into from
Jan 30, 2023
Merged

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Jan 28, 2023

Closes #1

One of the largest dependencies that Storybook installs in user projects is core-js, and one of the reasons it does so is because of this package.

The changes here remove babel in exchange for building with rollup via unbuild (https://github.com/unjs/unbuild), which greatly simplifies the dependencies.

This also bumps dotenv and dotenv-expand.

This also updates jest, and adds a github workflow to replace Travis.

@socket-security
Copy link

Socket Security Pull Request Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
[email protected] (added) postinstall package.json via [email protected]
😵‍💫 Bin script confusion

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack

Consider removing one of the conflicting packages. Packages should only export bin scripts with their name

Package Bin script Source
[email protected] (upgraded) jest package.json
[email protected] (upgraded) jest package.json via [email protected]
⚠️ Uses eval

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

Package Eval Type Location Source
[email protected] (upgraded) Function build/utils.js package.json via [email protected]
[email protected] (added) Function dist/js-yaml.js package.json via [email protected]
[email protected] (added) Function dist/js-yaml.js package.json via [email protected]
[email protected] (added) Function lib/js-yaml/type/js/function.js package.json via [email protected]
[email protected] (added) Function lib/js-yaml/type/js/function.js package.json via [email protected]
[email protected] (upgraded) Function dist/shared/loadConfigFile.js package.json via [email protected]
[email protected] (upgraded) Function dist/shared/loadConfigFile.js package.json via [email protected]
@sinonjs/[email protected] (added) eval src/fake-timers-src.js package.json via [email protected]
⚠️ New author

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Package New Author Previous Author Source
[email protected] (upgraded) stevemao shinnn package.json via [email protected]
[email protected] (upgraded) gnoff acdlite package.json via [email protected]
@babel/[email protected] (added) jlhwung nicolo-ribaudo package.json via [email protected]
@babel/[email protected] (added) jlhwung nicolo-ribaudo package.json via [email protected]
@babel/[email protected] (added) jlhwung nicolo-ribaudo package.json via [email protected]
[email protected] (upgraded) oss-bot coreyfarrell package.json via [email protected]
[email protected] (upgraded) oss-bot coreyfarrell package.json via [email protected]
[email protected] (upgraded) bolinfest wez package.json via [email protected]
[email protected] (upgraded) phated paulmillr package.json via [email protected]
[email protected] (upgraded) lukekarrys gar package.json via [email protected]
[email protected] (upgraded) phated thlorenz package.json via [email protected]
[email protected] (upgraded) gar lukekarrys package.json via [email protected]
Pull request report summary
Issue Status
Install scripts ⚠️ 1 issue
Native code ✅ 0 issues
Bin script confusion ⚠️ 2 issues
Bin script shell injection ✅ 0 issues
Shell access ✅ 0 issues
Uses eval ⚠️ 8 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
GitHub dependency ✅ 0 issues
New author ⚠️ 12 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
AI detected malware ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

bin/unienv Outdated Show resolved Hide resolved
@ndelangen ndelangen merged commit fb6f34b into master Jan 30, 2023
@ndelangen ndelangen deleted the remove-babel branch January 30, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants