Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addons catalog integrate back-end #201

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Addons catalog integrate back-end #201

merged 3 commits into from
Jan 19, 2021

Conversation

winkerVSbecks
Copy link
Contributor

  • Addon detail pages
  • Search
  • Wired up popular and trending addons for home page
  • Linked tags

@winkerVSbecks winkerVSbecks force-pushed the addons-back-end-integration branch 5 times, most recently from 08457d5 to c9bb8f2 Compare January 15, 2021 18:52
@winkerVSbecks winkerVSbecks force-pushed the addons-back-end-integration branch 4 times, most recently from 024b2c0 to 82d9bbe Compare January 18, 2021 16:55
@winkerVSbecks
Addons catalog integrate back-end
7493987 
* Addon detail pages
* Search
* Wire up Popular and trending addons for home page
* Linked tags
@winkerVSbecks winkerVSbecks force-pushed the addons-back-end-integration branch 2 times, most recently from dfd953c to 1cc30a5 Compare January 19, 2021 03:56
shilman
shilman approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! In addition to my request below, a style suggestion would be to use async/await which is a little more readable than promise chains. Not a big deal though.

src/util/create-addons-pages.js Outdated Show resolved Hide resolved
@winkerVSbecks winkerVSbecks force-pushed the addons-back-end-integration branch 2 times, most recently from 502804b to 82869ca Compare January 19, 2021 18:55
@kylesuss
Copy link
Collaborator

I've been getting some emails from Netlify about insecure content in the deploys from this branch:

https://app.netlify.com/sites/storybook-frontpage/deploys/600729ef9bf4be00075571b7

Is this something we can silence/fix?

@winkerVSbecks
Copy link
Contributor Author

@kylesuss we are rendering Readme's which contain images that are not https. I'm not sure how to resolve it since it is user generated content. But, will look into silencing it.

@winkerVSbecks winkerVSbecks force-pushed the addons-back-end-integration branch from 82869ca to e7722ae Compare January 19, 2021 19:04
@winkerVSbecks winkerVSbecks merged commit c7ca43c into master Jan 19, 2021
@winkerVSbecks winkerVSbecks deleted the addons-back-end-integration branch January 19, 2021 19:18
@rbardini rbardini mentioned this pull request Jan 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@kylesuss kylesuss Awaiting requested review from kylesuss

@domyen domyen Awaiting requested review from domyen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winkerVSbecks @kylesuss @shilman