-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to add support for CSF3 render preset #76
Conversation
@@ -57,7 +57,7 @@ module.exports.generateIframeScriptCode = | |||
.map((entry) => `// preview entry\nimport '${entry}';`) | |||
.join('\n')} */ | |||
|
|||
import { addDecorator, addParameters, addLoader, addArgTypesEnhancer, addArgsEnhancer } from '@storybook/client-api'; | |||
import { addDecorator, addParameters, addLoader, addArgTypesEnhancer, addArgsEnhancer, setGlobalRender } from '@storybook/client-api'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like setGlobalRender
is not exported by https://github.com/storybookjs/storybook/blob/c1befe4b2400920a6c52fdc947d8e598cc7e35e1/lib/client-api/src/index.ts#L1-L7
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK that's a bug. Here's the actual line that does the work:
Should we bump the Storybook version? Seems like the Github Action installed 6.3.3. |
Hi @shilman, what's the status on this PR? |
Looking forward to make use of this feature. Keep up the great work! 🙂 |
25a72fa
to
cfbeccd
Compare
I rebased this on master and tested it out. But the story seems to render fine with and without the changes in this PR. It would be good to have an example of a story example that fails without this PR and which should work correctly with it. |
52e7949
to
cc2ba9e
Compare
Well, I think this PR is "working", but I'm not really sure what it's supposed to be doing. I thought this would allow us to use automatic title generation, but that doesn't seem to be the case. I've removed the
|
closing in favor of #194 |
Issue: N/A
What I did
What I need
Trying to test it out, but the example is failing with the error:
This is strange because AFAIK that export exists, even in 6.3