Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add typescript check when adding react-docgen-typescript plugin #509

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Re-add typescript check when adding react-docgen-typescript plugin #509

merged 1 commit into from
Oct 7, 2022

Conversation

joshwooding
Copy link
Member

@joshwooding joshwooding commented Oct 5, 2022 •
edited
Loading

A hybrid of #460 and #313.

I believe this approach matches how storybook works with webpack.

@joshwooding joshwooding requested a review from IanVS October 5, 2022 23:23
IanVS
IanVS approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@IanVS IanVS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. Would you like to make the same change for the 7.0 vite-builder as well (frameworks/react-vite)?

@joshwooding joshwooding marked this pull request as ready for review October 7, 2022 10:11
@joshwooding joshwooding merged commit 64879c1 into main Oct 7, 2022
@joshwooding joshwooding deleted the readd-typescript-present-check branch October 7, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanVS IanVS IanVS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshwooding @IanVS