Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure mocked actions can be identified in production build #482

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

bodograumann
Copy link
Contributor

  • Enable esbuild keep names as workaround
  • Add interactive test in vue example

Not sure if the tests should be kept in, as they add a lot of dependencies to the example.

Fixes #206.

resolve: { alias: [{ find: '@assets', replacement: resolve(__dirname, '..', 'stories', 'assets') }] },
resolve: {
alias: [{ find: '@assets', replacement: resolve(__dirname, '..', 'stories', 'assets') }],
dedupe: ['@storybook/client-api'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dedupe is only necessary if there are different storybook versions being installed. I see that @storybook/addon-interactions doesn't match the rest, but from discord it sounded like this error started before you added that addon. If you install addon-interactions 6.5.9, is this dedupe still needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I invistigated with yarn why and set @storybook/vue3 as well as @storybook/addon-interactions to 6.5.9 as fixed version.This seems to work.

@IanVS IanVS merged commit 0affa70 into storybookjs:main Aug 23, 2022
@IanVS
Copy link
Member

IanVS commented Aug 23, 2022

Thanks @bodograumann!

@bodograumann bodograumann deleted the fix-action-mocks@206 branch June 1, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actions are not mocked for interaction tests in production build
2 participants