Set up addon channel before importing addons #301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes storybookjs/storybook#17852
This also re-organizes our virtual filenames a bit, putting them in a single file that can be imported from various spots, rather than having to pass around the strings as extra options.
To fix the issue, I pulled out the code that sets up the addon channel from the "modern" approach, and import that at the start of the non-static-store code. It needed to be a separate file due to the way es module imports work, otherwise addon code will be imported before the channel can be created, if we tried to do it all in one file. Bonus points for getting to share some code between the two approaches, I guess.