Move import of framework module after configs #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwooding
approved these changes
Mar 27, 2022
IanVS
added a commit
that referenced
this pull request
Apr 3, 2022
This reverts commit 0f14b29. # Conflicts: # packages/builder-vite/codegen-iframe-script.ts
IanVS
added a commit
that referenced
this pull request
Apr 8, 2022
This reverts commit 0f14b29. # Conflicts: # packages/builder-vite/codegen-iframe-script.ts
IanVS
added a commit
that referenced
this pull request
Apr 8, 2022
This reverts commit 0f14b29. # Conflicts: # packages/builder-vite/codegen-iframe-script.ts
IanVS
added a commit
that referenced
this pull request
Apr 8, 2022
Closes #305 This reverts #289, and fixes it a better way, by replacing filesystem imports (`/@fs/` style absolute path imports) with normal node_modules style imports. So, instead of: ``` /@fs/Users/ianvs/code/experiments/sb-builder-vite-no-container/node_modules/@storybook/vue3/dist/esm/client/preview/config ``` We'll import from ``` @storybook/vue3/dist/esm/client/preview/config ``` Which vite can correctly pre-bundle and add a browserHash to. To test this, run the vue example in this repo. You should see some messages about new dependencies being optimized in the terminal, and the storybook should load up just fine with no errors about `No docs.container set`. I tested this out back to our minimum supported versions of vite (2.5.2) and storybook (6.4.0). It worked fine, although at that old version, one page refresh was required on the very first startup (due to changes in pre-bundled deps). This doesn't happen in vite 2.9.0, which has better support for finding new deps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix storybookjs/storybook#17773. You can check it in the vue example of this repo. In main, the docs tab does not work, and neither does the introduction story. But with this PR, it does. This also aligns us more closely with the webpack builder, which imports the
configurefunction in the virtual story entry, not the config entry. I tested this change in our examples back to storybook 6.4.0.