Enable auto-title for non-storyStoreV7 #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was seeing the issue with identical stories in the sidebar too but couldn't reproduce it :/ Hopefully #182 fixes it. |
IanVS
force-pushed
the
issue/201-autotitle
branch
from
de994d5 to
9ff5c41
Compare
|
OK, I've rebased this onto #182 (which turns out probably wasn't strictly necessary), and made a small change to what is stored as The last issue I'm seeing is that HMR does not seem to be working correctly, and the page refreshes instead of hot reloading. |
|
Hmmmm, it seems like HMR is broken and the whole page refreshes on |
IanVS
requested review from
eirslett and
joshwooding
and removed request for
eirslett and
joshwooding
IanVS
force-pushed
the
issue/201-autotitle
branch
from
9ff5c41 to
2773ac1
Compare
We need this version because it removes a `path` import from some browser code.
IanVS
force-pushed
the
issue/201-autotitle
branch
from
2773ac1 to
c89b67d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201
This enables the omission of
titleproperties in the default export of stories (the new storybook "autotitle" feature). It's a little less powerful without #182, but it's still nice to support this, I think.I did notice an issue with HMR, but it seems not to be introduced in this PR, but exists in the react example on main as well. Changing a css value does still HMR, so I think there is no regression here.