expect __docgenInfo to be before the HoC call #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've managed to make this change and updated the tests too. Its all green ✅ |
|
I'm having similar issues and seems like your commits will fix those. Thanks for that. |
|
Yeah, I'm wondering the same. For now I am just using my forked version. Let's hope contributors look at this PR soon. |
|
my apologies for the late review, I will take a look at this later today |
|
published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think #48 deserves to be re-opened. The problem isn't that it doesn't support HoC, the problem is that the
__docgenInfois set after the HoC call. This doesn't let the HoC wrapper hoist the statics into the parent component and hence even though the__docgenInfois created, it is hidden underneath the HoC wrapper.I am opening this PR to start a discussion.
__docgenInfobefore HoC call/cc @danielduan @madushan1000