Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ESM support #30

Merged
merged 9 commits into from
Jun 10, 2021
Merged

Add ESM support #30

merged 9 commits into from
Jun 10, 2021

Conversation

TheComputerM
Copy link
Contributor

@TheComputerM TheComputerM mentioned this pull request Jun 8, 2021
Closed
@shilman
Copy link
Member

shilman commented Jun 9, 2021 •
edited
Loading

@TheComputerM can you please resolve conflicts on these files?
@j3rem1e can you please review the changes?

@shilman shilman added the enhancement New feature or request label Jun 9, 2021
@shilman shilman added the minor Increment the minor version when merged label Jun 9, 2021
@shilman shilman changed the title add ESM support Add ESM support Jun 9, 2021
@shilman
Copy link
Member

shilman commented Jun 9, 2021

@TheComputerM thanks for updating. i get the following error when testing. can you please look into it?

$ yarn storybook
ERR! Error: Cannot find module './dist/esm/preset/preview'
...

@TheComputerM
Copy link
Contributor Author

TheComputerM commented Jun 9, 2021 •
edited
Loading

@shilman Fixed the code.

@TheComputerM
Copy link
Contributor Author

Thank you very much @shilman ! Please @ me if there are any issues.

shilman
shilman reviewed Jun 10, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit 9b7a7fd into storybookjs:main Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman left review comments

Assignees
No one assigned
Labels
enhancement New feature or request minor Increment the minor version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheComputerM @shilman