Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Svelte 5 Support #177

Closed
wants to merge 10 commits into from
Closed

Conversation

tsar-boomba
Copy link

Updates some dependencies:

  • Storybook
  • estree
  • svelte
  • vite
  • vitest

Issues

  1. Collect stories test cannot pass even though the addon works fine in actual storybook
  2. Args to components cannot be inferred when using runes mdoe in a component. For example, in the ArgsTable story, you cannot tweak any of the props from the story ui.

LuisEGR and others added 10 commits February 20, 2024 13:15
Updated the Getting Started instruction number 3, this was quite confusing, initially says add "*.stories.svelte" which if taked literary, one can think of adding this string as a new element to the array, but after closing inspection (because it is not working), one can realize in the example the correct configuration, all this can be avoided if the instructions are clearer.
Updated point 3 of the getting started to avoid confusion.
@xeho91
Copy link
Collaborator

xeho91 commented May 6, 2024

Hi, this is just a heads up.

I've had a time to do some research with Storybook support for Svelte 5, including this addon.

While testing your PR, I've noticed that the stories in the group MetaExport doesn't work at runtime.

EDIT:
@tsar-boomba I was motivated enough to try my luck, and I've got it partially working by aggressively dropping support for v4 and removing the deprecated features such as component Meta. The only issue left I have is with correct parsing the of few meta export key properties such as title to pass the tests.

I've branched out from your branch. I do not wish to interrupt your contribution, so I've added you to Discord (my username is xeho91). Please let's discuss how I can help you, and show you what I've done. Thanks!

@xeho91
Copy link
Collaborator

xeho91 commented May 6, 2024

There's my attempt:
tsar-boomba#1

Feel free to copy/cherry-pick/whatever, and let me know if I can help more with testing/contributing.

@xeho91 xeho91 mentioned this pull request May 7, 2024
@JReinhold
Copy link
Collaborator

@xeho91 could you open a PR directly to this repo, so that we're not all blocked by each other?

Feel free to attribute relevant changes to @tsar-boomba

@xeho91 xeho91 mentioned this pull request May 14, 2024
23 tasks
@tsar-boomba
Copy link
Author

tsar-boomba commented May 14, 2024

Closing in favor of #181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants